From aa2d8b024ff157b229a152f306eb9a7ee4f8ab50 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sun, 22 Aug 2021 14:20:55 +0000 Subject: [PATCH] Bug 24406: Wrap patron category type code in a span on patron search results The patron category type code (A, C, O, ...) is currently displayed in the patron module search and the patron card creator and acquisition patron searches. This information is not useful for most users, as these are internal codes that cannot be easily "decoded". And while you might be able to guess A as Adult in English, it doesn't translate to other languages. This patch wraps a span around the patron category type code shown in () after the patron category. To test: - Verify for each of the following three searches, that the patron category code displays in the search results, but is wrapped in a span with the class patron_category_type - Tools > Patron card creator - New > New card batch > Add patrons - Search for patrons - Patrons - Search for patrons - Acquisitions - Add a budget - Add a fund for the budget - Search for a user or owner to add Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart --- .../prog/en/modules/acqui/tables/members_results.tt | 2 +- .../prog/en/modules/members/tables/members_results.tt | 2 +- .../prog/en/modules/patroncards/tables/members_results.tt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt index b90a8d795d..50cc702350 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/tables/members_results.tt @@ -13,7 +13,7 @@ "dt_branch": "[% data.branchname | html %]", "dt_category": - "[% data.category_description | html %] ([% data.category_type | html %])", + "[% data.category_description | html %] ([% data.category_type | html %])", "dt_action": [%- IF selection_type == 'select' -%] "Select" diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt index e19f2c0382..d20d6add80 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt @@ -23,7 +23,7 @@ "dt_dateofbirth": "[% INCLUDE 'patron-age.inc' patron = data %]", "dt_category": - "[% data.category_description | html | $To %] ([% data.category_type | html | $To %])", + "[% data.category_description | html | $To %] ([% data.category_type | html | $To %])", "dt_branch": "[% data.branchname | html | $To %]", "dt_dateexpiry": diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt index f4af6752af..9660e3e56e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/tables/members_results.tt @@ -11,7 +11,7 @@ "dt_name": "[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = To.json(data.firstname) surname = To.json(data.surname) othernames = To.json(data.othernames) cardnumber = data.cardnumber invert_name = 1%]", "dt_category": - "[% data.category_description | html %] ([% data.category_type | html %])", + "[% data.category_description | html %] ([% data.category_type | html %])", "dt_branch": "[% data.branchname | html %]", "dt_dateexpiry": -- 2.39.5