From aa9fb9962a1e1437c32264fb7e870cc13a0ad87d Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 26 Dec 2023 10:53:07 -0300 Subject: [PATCH] Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer (cherry picked from commit ba3130a88a26c96b133c1a709b1afea9828d6120) Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 2 +- .../intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/authorised_values.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/biblio_framework.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt | 2 +- .../prog/en/modules/admin/identity_provider_domains.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/identity_providers.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/usage_statistics.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/circ/request-article.tt | 2 +- .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 ++-- .../prog/en/modules/tools/additional-contents.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/holds.js | 4 ++-- koha-tmpl/intranet-tmpl/prog/js/modals/display_ticket.js | 4 ++-- koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 2 +- 24 files changed, 30 insertions(+), 30 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc index 4a9b203782..f7b139fd68 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc @@ -762,7 +762,7 @@ } }, error: function() { - alert( _("An error occurred. Check the logs") ); + alert( _("An error occurred. Check the logs for details.") ); } }); } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt index 377b9fcb5a..74d6c779b6 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/vendor_issues.tt @@ -71,7 +71,7 @@ [% CASE 'error_on_insert' %] An error occurred when adding this issue [% CASE 'error_on_delete' %] - An error occurred when deleting this issue. Check the logs. + An error occurred when deleting this issue. Check the logs for details. [% CASE 'success_on_update' %] Issue updated successfully. [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt index 5b99965925..a7915d3189 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt @@ -214,9 +214,9 @@ [% CASE 'error_on_insert_cat' %] An error occurred when inserting this authorized value category. Perhaps the category name already exists. [% CASE 'error_on_delete' %] - An error occurred when deleting this authorized value. Check the logs. + An error occurred when deleting this authorized value. Check the logs for details. [% CASE 'error_on_delete_category' %] - An error occurred when deleting this authorized value category. Check the logs. + An error occurred when deleting this authorized value category. Check the logs for details. [% CASE 'success_on_update' %] Authorized value updated successfully. [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt index a9229ee6fc..d6d2dd059c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt @@ -88,7 +88,7 @@ [% CASE 'error_on_insert' %] An error occurred when adding this authority type. The authority type code might already exist. [% CASE 'error_on_delete' %] - An error occurred when deleting this authority type. Check the logs. + An error occurred when deleting this authority type. Check the logs for details. [% CASE 'success_on_update' %] Authority type updated successfully. [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt index 540988a26d..24bc056e30 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt @@ -82,7 +82,7 @@ [% CASE 'error_on_insert' %] An error occurred when adding this framework. The framework might already exist. [% CASE 'error_on_delete' %] - An error occurred when deleting this framework. Check the logs. + An error occurred when deleting this framework. Check the logs for details. [% CASE 'success_on_update' %] Framework updated successfully. [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt index c8d547097d..16ccfaa968 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ -86,7 +86,7 @@ [% CASE 'error_on_insert' %] An error occurred when adding this library. The branchcode might already exist. [% CASE 'error_on_delete' %] - An error occurred when deleting this library. Check the logs. + An error occurred when deleting this library. Check the logs for details. [% CASE 'success_on_update' %] Library updated successfully. [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt index a1990144c4..f7db66af0d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt @@ -97,7 +97,7 @@ [% CASE 'error_on_insert' %] An error occurred when inserting this patron category. The patron category might already exist. [% CASE 'error_on_delete' %] - An error occurred when deleting this patron category. Check the logs. + An error occurred when deleting this patron category. Check the logs for details. [% CASE 'success_on_update' %] Patron category updated successfully. [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt index c5b756a125..9d1dfe19d1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt @@ -76,7 +76,7 @@ [% CASE 'error_on_insert' %] An error occurred when adding this city. The city ID might already exist. [% CASE 'error_on_delete' %] - An error occurred when deleting this city. Check the logs. + An error occurred when deleting this city. Check the logs for details. [% CASE 'success_on_update' %] City updated successfully. [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt index aaf7c46438..efb104a1d0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt @@ -83,7 +83,7 @@ [% CASE 'error_on_insert' %] An error occurred when adding this currency. The currency code might already exist [% CASE 'error_on_delete' %] - An error occurred when deleting this currency. Check the logs + An error occurred when deleting this currency. Check the logs for details. [% CASE 'success_on_update' %] Currency updated successfully [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt index 62ee07a528..c72629441a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt @@ -75,7 +75,7 @@ [% CASE 'error_on_insert' %] An error occurred when adding this desk. The desk ID might already exist [% CASE 'error_on_delete' %] - An error occurred when deleting this desk. Check the logs + An error occurred when deleting this desk. Check the logs for details. [% CASE 'success_on_update' %] Desk updated successfully [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt index 63b017e256..77b1feb30e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt @@ -477,7 +477,7 @@ $("#smtp_delete_success").html(_("Server '%s' deleted successfully.").format(identity_provider_domain)).show(); }); }).fail(function () { - $("#smtp_delete_error").html(_("Error deleting server '%s'. Check the logs.").format(identity_provider_domain)).show(); + $("#smtp_delete_error").html(_("Error deleting server '%s'. Check the logs for details.").format(identity_provider_domain)).show(); }).done(function () { $("#delete_confirm_modal").modal('hide'); }); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt index 95c56756ce..a94dc964dd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt @@ -482,7 +482,7 @@ $("#identity_provider_delete_success").html(_("Server '%s' deleted successfully.").format(identity_provider_code)).show(); }); }).fail(function () { - $("#identity_provider_delete_error").html(_("Error deleting server '%s'. Check the logs.").format(identity_provider_code)).show(); + $("#identity_provider_delete_error").html(_("Error deleting server '%s'. Check the logs for details.").format(identity_provider_code)).show(); }).done(function () { $("#delete_confirm_modal").modal('hide'); }); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt index 5a093affbe..97fdc778f3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt @@ -124,7 +124,7 @@ [% CASE 'error_on_insert' %] An error occurred when inserting this item type. Perhaps the value already exists [% CASE 'error_on_delete' %] - An error occurred when deleting this item type. Check the logs + An error occurred when deleting this item type. Check the logs for details. [% CASE 'success_on_update' %] Item type updated successfully [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt index 76e27e39ab..8214ac9851 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt @@ -475,7 +475,7 @@ $("#smtp_delete_success").html(_("Server '%s' deleted successfully.").format(smtp_server_name)).show(); }); }).fail(function () { - $("#smtp_delete_error").html(_("Error deleting server '%s'. Check the logs.").format(smtp_server_name)).show(); + $("#smtp_delete_error").html(_("Error deleting server '%s'. Check the logs for details.").format(smtp_server_name)).show(); }).done(function () { $("#delete_confirm_modal").modal('hide'); }); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt index 2311248d01..960bea41cc 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt @@ -44,7 +44,7 @@ [% CASE 'error_on_insert' %] An error occurred when inserting this patron category. The patron category might already exist [% CASE 'error_on_delete' %] - An error occurred when deleting this patron category. Check the logs + An error occurred when deleting this patron category. Check the logs for details. [% CASE 'success_on_update' %] Patron category updated successfully [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 19d15b726d..ccdcb8ed25 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -2032,10 +2032,10 @@ if ( response.error_code === "failed_nesting" ) { $('#addResult').replaceWith('
'+_("Failure: Item '%s' is a bundle and bundles cannot be nested").format(barcode)+'
'); } else { - $('#addResult').replaceWith('
'+_("Failure: Check the logs for details")+'
'); + $('#addResult').replaceWith('
'+_("Failure: Check the logs for details.")+'
'); } } else { - $('#addResult').replaceWith('
'+_("Failure: Check the logs for details")+'
'); + $('#addResult').replaceWith('
'+_("Failure: Check the logs for details.")+'
'); } $('#external_id').val('').focus(); }); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt index 18c32347fd..fde96d0372 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt @@ -99,7 +99,7 @@
[% SWITCH error_message %] [% CASE 'article_request_limit_reached' %]

Patron reached daily limit.

- [% CASE 'article_request_unhandled_exception' %]

An error has occurred. Check the logs.

+ [% CASE 'article_request_unhandled_exception' %]

An error has occurred. Check the logs for details.

[% END %]
[% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index 816b7f088f..fa4b2d373c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -72,9 +72,9 @@ legend:hover { [% FOR message IN borrower_data.messages %] [% SWITCH message.error %] [% CASE 'error_on_insert_patron' %] -
Something went wrong when creating the patron. Check the logs.
+
Something went wrong when creating the patron. Check the logs for details.
[% CASE 'error_on_update_patron' %] -
Something went wrong when updating the patron. Check the logs.
+
Something went wrong when updating the patron. Check the logs for details.
[% CASE %]
Unhandled error: [% message.error | html %]
[% END %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt index cf372332c3..2d56f7f689 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt @@ -129,9 +129,9 @@ [% CASE 'error_on_update' %] An error occurred when updating this content. Perhaps it already exists [% CASE 'error_on_insert' %] - An error occurred when adding this content. Check the logs + An error occurred when adding this content. Check the logs for details. [% CASE 'error_on_delete' %] - An error occurred when deleting this content. Check the logs + An error occurred when deleting this content. Check the logs for details. [% CASE 'success_on_update' %] Content updated successfully [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt index 4dcd7b7de2..64f2984d52 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt @@ -70,7 +70,7 @@ [% CASE 'error_on_insert' %] An error occurred when adding this CSV profile [% CASE 'error_on_delete' %] - An error occurred when deleting this CSV profile. Check the logs + An error occurred when deleting this CSV profile. Check the logs for details. [% CASE 'success_on_update' %] CSV profile updated successfully [% CASE 'success_on_insert' %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt index d2829a5da0..2cafb7ed69 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt @@ -255,7 +255,7 @@ $("#quote_delete_success").html(_("Quote #%s deleted successfully.").format(quote_id)).show(); }); }).error(function () { - $("#quote_delete_error").html(_("Error deleting quote #%s. Check the logs.").format(quote_id)).show(); + $("#quote_delete_error").html(_("Error deleting quote #%s. Check the logs for details.").format(quote_id)).show(); }); }); }); diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js index 50dce1ddd3..460fa4dec0 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/holds.js +++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js @@ -350,7 +350,7 @@ $(document).ready(function() { alert(__("Unable to resume, hold not found")); } else { - alert(__("Your request could not be processed. Check the logs")); + alert(__("Your request could not be processed. Check the logs for details.")); } holdsTable.api().ajax.reload(); }); @@ -436,7 +436,7 @@ $(document).ready(function() { alert(__("Unable to suspend, hold not found")); } else { - alert(__("Your request could not be processed. Check the logs")); + alert(__("Your request could not be processed. Check the logs for details.")); } holdsTable.api().ajax.reload(); }).done(function() { diff --git a/koha-tmpl/intranet-tmpl/prog/js/modals/display_ticket.js b/koha-tmpl/intranet-tmpl/prog/js/modals/display_ticket.js index 653f3f9726..b35a3a7557 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/modals/display_ticket.js +++ b/koha-tmpl/intranet-tmpl/prog/js/modals/display_ticket.js @@ -86,7 +86,7 @@ $(document).ready(function() { $("#concern_delete_success").html(__("Concern #%s updated successfully.").format(ticket_id)).show(); }); }).error(function() { - $("#concern_update_error").html(__("Error resolving concern #%s. Check the logs.").format(ticket_id)).show(); + $("#concern_update_error").html(__("Error resolving concern #%s. Check the logs for details.").format(ticket_id)).show(); }); }); @@ -114,7 +114,7 @@ $(document).ready(function() { $("#concern_delete_success").html(__("Concern #%s updated successfully.").format(ticket_id)).show(); }); }).error(function() { - $("#concern_update_error").html(__("Error resolving concern #%s. Check the logs.").format(ticket_id)).show(); + $("#concern_update_error").html(__("Error resolving concern #%s. Check the logs for details.").format(ticket_id)).show(); }); }); }); diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js index f5dd4f9186..ab24a9304e 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -470,7 +470,7 @@ function patron_autocomplete(node, options) { }, error: function (e) { if (e.state() != 'rejected') { - alert(__("An error occurred. Check the logs")); + alert(__("An error occurred. Check the logs for details.")); } return response(); } -- 2.39.5