From ac5a9f2694cc6c1ac2929268024eff520602d20d Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 10 Nov 2020 12:55:17 +0100 Subject: [PATCH] Bug 26973: [20.05.x] (bug 26119 follow-up) Restore patron's attributes during self-registration The assumption on bug 26119 was wrong. We actually store patron's attributes during self-registration if PatronSelfRegistrationVerifyByEmail is not enabled. Test plan: Test the different combinations of PatronSelfRegistration and PatronSelfRegistrationVerifyByEmail Confirm that the patron's attributes appears during self-registration if PatronSelfRegistrationVerifyByEmail is not set. Confirm that the patron's attributes are stored when they are displayed on the self-registration form Confirm that you can edit the patron's attributes in any cases (if they are marked as editable at the OPAC) Signed-off-by: Lucas Gass --- .../intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt index 5629aa65cd..7378d9b935 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt @@ -116,7 +116,7 @@ [% ELSE %] [% END %] - Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work during self-registration.) + Check to allow patrons to edit this attribute from their details page in the OPAC. (Requires above, does not work during self-registration if PatronSelfRegistrationVerifyByEmail if set.)
  • [% IF attribute_type AND attribute_type.staff_searchable %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 6d40688320..0b27941a7b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -892,7 +892,7 @@ [% END %] - [% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && action != 'new' ) %] + [% IF ( Koha.Preference('ExtendedPatronAttributes') && patron_attribute_classes.size && ! ( action == 'new' && Koha.Preference('PatronSelfRegistrationVerifyByEmail') ) ) %] [% FOREACH pa_class IN patron_attribute_classes %] [% IF pa_class.class %]
    -- 2.39.5