From aeef2fadc39ce019e4f665621d282b088f9a2704 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 4 Nov 2020 09:04:19 +0100 Subject: [PATCH] Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 42c0475a948577442e44b11dbb12b45b25171418) Signed-off-by: Lucas Gass --- members/pay.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/members/pay.pl b/members/pay.pl index eb16f04574..2fb35315da 100755 --- a/members/pay.pl +++ b/members/pay.pl @@ -122,7 +122,7 @@ elsif ( $input->param('confirm_writeoff') ) { interface => C4::Context->interface, library_id => $branch, } - ); + )->{payment_id}; } } -- 2.39.5