From c6133753ed661902a9ec3cce14190c7d3d683ef0 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 31 Jul 2018 12:43:54 -0300 Subject: [PATCH] Bug 21134: Correctly throw the exception in Koha::Patron::Modification->approve koha_1 | # Looks like you planned 20 tests but ran 9. koha_1 | koha_1 | # Failed test 'approve tests' koha_1 | # at t/db_dependent/Koha/Patron/Modifications.t line 259. koha_1 | [Something went wrong]# Looks like your test exited with 255 just after 5. koha_1 | [21:13:47] t/db_dependent/Koha/Patron/Modifications.t ..................... "Something went wrong" should never been thrown, Koha::Patron::Modification->approve raises $@, but it's not defined, it should raise $_ instead Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6e99cfbca7e904b7664163838a334c487c94e462) Signed-off-by: Martin Renvoize --- Koha/Patron/Modification.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/Patron/Modification.pm b/Koha/Patron/Modification.pm index 0fb1d0bbdc..b0e01b7378 100644 --- a/Koha/Patron/Modification.pm +++ b/Koha/Patron/Modification.pm @@ -146,7 +146,7 @@ sub approve { Koha::Exceptions::Patron::Modification->throw( $_->{msg} ); } else { - Koha::Exceptions::Patron::Modification->throw($@); + Koha::Exceptions::Patron::Modification->throw($_); } }; } -- 2.39.5