From c663876e105324feb7fce616ea19a6a1e1d421fe Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 26 May 2021 11:16:13 -0400 Subject: [PATCH] Bug 28464: Remove useless check that gives the incorrect error message Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall --- C4/SIP/ILS.pm | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm index 112eb201c3..8ec70e3b7c 100644 --- a/C4/SIP/ILS.pm +++ b/C4/SIP/ILS.pm @@ -361,13 +361,7 @@ sub cancel_hold { return $trans; } # Remove the hold from the patron's record first - $trans->ok($patron->drop_hold($item_id)); # different than the transaction drop! - - unless ($trans->ok) { - # We didn't find it on the patron record - $trans->screen_msg("No such hold on patron record."); - return $trans; - } + $patron->drop_hold($item_id); # different than the transaction drop! # Now, remove it from the item record. If it was on the patron # record but not on the item record, we'll treat that as success. -- 2.39.5