From c80d4655cc56eb5afe0f4a24ac75dbbfdadb01b5 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 11 Mar 2021 08:03:13 -0300 Subject: [PATCH] Bug 27760: (QA follow-up) Improve POD This patch improves the POD for the added helper, and also adds references to the JSON::Validator issue that explains the current implementation. A FIXME is added for when we upgrade our used JSON::Validator version. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart --- Koha/REST/Plugin/Query.pm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Koha/REST/Plugin/Query.pm b/Koha/REST/Plugin/Query.pm index d01d64d8fe..e6bb370d06 100644 --- a/Koha/REST/Plugin/Query.pm +++ b/Koha/REST/Plugin/Query.pm @@ -268,7 +268,19 @@ Merges parameters from $q_params into $filtered_params. =head3 stash_overrides + # Stash the overrides $c->stash_overrides(); + #Use it + my $overrides = $c->stash('koha.overrides'); + if ( $overrides->{pickup_location} ) { ... } + +This helper method parses 'x-koha-override' headers and stashes the passed overriders +in the for of a I for easy use in controller methods. + +FIXME: With the currently used JSON::Validator version we use, it is not possible to +use the validated and coerced data (it doesn't validate array-type headers) so this +implementation relies on manual parsing. Look at the JSON::Validator changelog for +reference: https://metacpan.org/changes/distribution/JSON-Validator#L14 =cut -- 2.39.5