From cd66aa48de0dda6af5ec4e130905899ec202dbf7 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 28 Apr 2021 17:56:11 +0000 Subject: [PATCH] Bug 28255: Follow up to bug 23463 - use item_object in misc/cronjobs/delete_items.pl This looks like just an assumption that the $item variable was an object Correct the code to use $item_object To test: 1 - perl misc/cronjobs/delete_items.pl -where="barcode LIKE '%8'" --commit --verbose 2 - Can't call method "safe_delete" on unblessed reference at /usr/share/koha/bin/cronjobs/delete_items.pl line 67. 3 - Apply patch 4 - Repeat 5 - Success! You deleted a bunch of items Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 423421eb64f0130d9cb194e572f4ca89937b02a4) Signed-off-by: Fridolin Somers (cherry picked from commit bac2651c609a04afa5fc802d2f7092e8b4ab76c6) Signed-off-by: Andrew Fuerste-Henry --- misc/cronjobs/delete_items.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl index 5ca182daf1..df5d23aa66 100755 --- a/misc/cronjobs/delete_items.pl +++ b/misc/cronjobs/delete_items.pl @@ -63,7 +63,7 @@ DELITEM: while ( my $item = $GLOBAL->{sth}->{target_items}->fetchrow_hashref() ) my $item_object = Koha::Items->find($item->{itemnumber}); my $safe_to_delete = $item_object->safe_to_delete; if( $safe_to_delete eq '1' ) { - $item->safe_delete + $item_object->safe_delete if $OPTIONS->{flags}->{commit}; verbose "Deleting '$item->{itemnumber}'"; } else { -- 2.39.5