From d2eae82201ddc2b9dcab2a9d87e71496cc18b3b8 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 4 May 2021 16:38:27 +0200 Subject: [PATCH] Bug 28288: Prevent XSISBN.t to fail if service is returning 500 16:00:45 koha_1 | WARNING: URL Request Failed 500 read timeout 16:00:45 koha_1 | WARNING: URL Request Failed 500 read timeout 16:00:45 koha_1 | WARNING: URL Request Failed 500 Can't connect to www.librarything.com:443 16:00:45 koha_1 | # Looks like you planned 6 tests but ran 5. 16:00:45 koha_1 | [13:59:51] t/db_dependent/XISBN.t 16:00:45 koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) 16:00:45 koha_1 | Failed 1/6 subtests 16:00:45 koha_1 | (less 3 skipped subtests: 2 okay) Signed-off-by: Jonathan Druart (cherry picked from commit 640ba470cfe2ac82b4ae96dfe3b4f945252a212f) Signed-off-by: Fridolin Somers --- t/db_dependent/XISBN.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/XISBN.t b/t/db_dependent/XISBN.t index a9825e942f..ed34e5aa4d 100755 --- a/t/db_dependent/XISBN.t +++ b/t/db_dependent/XISBN.t @@ -60,7 +60,7 @@ t::lib::Mocks::mock_preference( 'ThingISBN', 1 ); my $results_thingisbn; eval { $results_thingisbn = C4::XISBN::get_xisbns($isbn1, $biblionumber4); }; SKIP: { - skip "Problem retrieving ThingISBN", 1 + skip "Problem retrieving ThingISBN", 2 unless $@ eq ''; ok( (any { $_->{'biblionumber'} eq $biblionumber1 } @$results_thingisbn), "Gets correct biblionumber from a book with a similar isbn using ThingISBN." ); -- 2.39.5