From da94410ab5022c3bd97fba1878673149802db584 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 13 May 2016 14:43:52 +0100 Subject: [PATCH] Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons Simple patch for a silly error, this single line is going to fix a critical bug. If a patron attribute is limited to a library, all the values for that attributes for every patrons will be deleted. Test plan: Create a patron attribute limited to a library Set the the attribute for a patron Set the the attribute for another patron => Without this patch applied, the attribute's value for the first patron is deleted => With this patch applied, the 2 values exist in the DB after the second edition Signed-off-by: Srdjan Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher --- C4/Members/Attributes.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm index 1036e581ed..b269532b2c 100644 --- a/C4/Members/Attributes.pm +++ b/C4/Members/Attributes.pm @@ -254,7 +254,7 @@ sub DeleteBorrowerAttributes { $query .= $branch_limit ? q{ LEFT JOIN borrower_attribute_types_branches ON bat_code = code - WHERE b_branchcode = ? OR b_branchcode IS NULL + WHERE ( b_branchcode = ? OR b_branchcode IS NULL ) AND borrowernumber = ? } : q{ -- 2.20.1