From dc7e886379b7035ae9dfc650d995f1e475ca1dff Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 26 Oct 2018 16:15:39 +0000 Subject: [PATCH] Bug 21693: Clean up checkout notes template This patch modifies the checkout notes template to help compliance with coding guidelines and interface patterns: - Convert to Bootstrap grid - Improve DataTables configuration - Put buttons into a toolbar and move above selection links Also corrected: Minor markup error in circ-nav.inc To test, apply the patch and enable the AllowCheckoutNotes system preference. Add a few checkout notes via the OPAC. - Go to Circulation -> Checkout notes. - Confirm that the page looks correct at various browser widths. - Confirm that the first and last columns of the table of notes are not sortable. - The table should be sorted by default by title. - Title sorting should ignore articles "a," "an," and "the." - Test with the CircSidebar preference both on and off. - With CircSidebar turn on, the checkout notes menu item in the left hand sidebar should show a count of checkout notes. Signed-off-by: Pierre-Marc Thibault Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens --- .../prog/en/includes/circ-nav.inc | 2 +- .../prog/en/modules/circ/checkout-notes.tt | 73 +++++++++++-------- 2 files changed, 43 insertions(+), 32 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc index 48f28d9322..bba7beac9b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc @@ -21,7 +21,7 @@
  • Fast cataloging
  • [% END %][% END %] [% IF Koha.Preference('AllowCheckoutNotes') && CAN_user_circulate_manage_checkout_notes %] -
  • Checkout notes [% IF pending_checkout_notes.count %][% pending_checkout_notes.count | html %][% END %]
  • +
  • Checkout notes [% IF pending_checkout_notes.count %][% pending_checkout_notes.count | html %][% END %]
  • [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt index dbad745f75..ce37428748 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt @@ -20,10 +20,17 @@ Checkout notes -[% IF Koha.Preference('CircSidebar') %]
    [% ELSE %]
    [% END %] -
    -
    - [% IF Koha.Preference('CircSidebar') %]
    [% END %] +
    +
    +
    +
    +
    + + [% IF Koha.Preference('CircSidebar') %] +
    + [% ELSE %] +
    + [% END %]

    Checkout notes

    @@ -42,30 +49,29 @@ [% END %] [% IF ( notes.count ) %] -
    - Select all - | Clear all - | Hide seen - | Show all -
    -
    - -
    +
    +
    + +
    + Select all + | Clear all + | Hide seen + | Show all
    - - + + - + @@ -98,21 +104,24 @@ [% ELSE %] - There are currently no checkout notes. +
    There are currently no checkout notes.
    [% END %] - - - [% IF Koha.Preference('CircSidebar') %] - - -
    - [% INCLUDE 'circ-nav.inc' %] -
    - [% END %] + [% IF Koha.Preference('CircSidebar') %] + +
    + +
    + [% ELSE %] + + [% END %] - - + + + + [% MACRO jsinclude BLOCK %] [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %] @@ -121,11 +130,13 @@
     Title Title Note Date Set by StatusActionsActions