From e4efbe396a7575a4b969b9caeab65ba60cf39d2f Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 5 Nov 2021 18:19:40 +0000 Subject: [PATCH] Bug 29430: Table cell click doesn't activate buttons in patron search MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Bug 15812 included a change which allows a click on the patron search results table cell to toggle the checkbox it contains. This patch modifies that click event so that it fires the change() event which is required for toggling the "Add to patron list" and "Merge patrons" buttons. To reproduce this problem, perform a patron search in the staff client which will return multiple results. - In the first column containing checkboxes, click in the empty part of the table cell. The checkbox should be checked. - However, the "Add to patron list" button remains disabled. - Clicking a table cell to check another checkbox should result in the "Merge selected patrons" button being enabled, but it doesn't. To test, apply the patch and repeat the process above. The behavior of the buttons should be the same whether you're clicking the checkbox itself or the table cell it's in. Signed-off-by: Barbara Johnson Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 1 + 1 file changed, 1 insertion(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt index 4a4e50650a..82d3a5bbb4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt @@ -586,6 +586,7 @@ var $checkbox = $(this).find("input[type=checkbox]"); if (e.target.type != "checkbox") { $checkbox.prop('checked', !$checkbox.prop("checked")); + $checkbox.change(); } }); -- 2.20.1