From e7cfb39a66dfc9f5af619ecd78bb757dfe4dec4e Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 6 Nov 2012 11:14:44 -0500 Subject: [PATCH] Bug 8955 [Follow-up] Self checkout should degrade gracefully w/o JavaScript This follow-up fixes some instance of unnecessary JavaScript which I missed the first time around: The renew and check-in buttons on the list of checkouts. The functionality can be easily accomplished without JS. Also corrected: - Capitalization error - Miss-named variable causing the "too many checkouts" not to be displayed - Misplaced [% END %] tags hidding "Return to account" button on some dialogs. - Corrected variable scope error which prevented the "return" button from appearing. To test, log into self checkout using an account which has checkouts. Testing renewing items both by scanning barcodes and by clicking the "renew" button in the list of checkouts. Renew something until it reaches its limit and test checking it out by scanning the barcode. Test the "check in" button. Signed-off-by: Chris Cormack Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov --- .../opac-tmpl/prog/en/modules/sco/sco-main.tt | 24 ++++++++++--------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt index 066e2c3a8b..729b2f375e 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt @@ -114,12 +114,12 @@ $(document).ready(function(){
[% IF ( impossible ) %] -

Item cannot be checked out.

Sorry, This item cannot be checked out at this station.

+

Item cannot be checked out.

Sorry, this item cannot be checked out at this station.

[% IF ( title ) %]

Title: [% title |html %]

[% END %]

[% IF ( circ_error_UNKNOWN_BARCODE ) %] MESSAGE 1: The system does not recognize this barcode. - [% ELSIF ( circ_error_TOO_MANY ) %] + [% ELSIF ( circ_error_max_loans_allowed ) %] MESSAGE 2: You have checked out too many items and can't check out any more. [% ELSIF ( circ_error_ISSUED_TO_ANOTHER ) %] MESSAGE 3: This item is checked out to someone else. @@ -158,6 +158,8 @@ $(document).ready(function(){ +[% END %] +[% END %]

@@ -165,8 +167,6 @@ $(document).ready(function(){
[% END %] -[% END %] -[% END %] [% IF ( confirm ) %]

Please confirm the checkout:

[% IF ( confirm_renew_issue ) %]This item is already checked out to you.[% END %]

@@ -276,19 +276,21 @@ Sorry, this self-checkout station has lost authentication. Please contact the a [% IF ( ISSUE.overdue ) %][% ISSUE.date_due | $KohaDates %][% ELSE %][% ISSUE.date_due | $KohaDates %][% END %]
- - [% IF ( ISSUE.norenew ) %] - [% IF ( ISSUE.AllowSelfCheckReturns ) %] - + [% IF ( AllowSelfCheckReturns ) %] + + + [% ELSE %] - No renewals allowed + No renewals allowed [% END %] [% ELSE %] - [% UNLESS ( ISSUE.renew ) %] - [% ELSE %][% END %] + + + [% UNLESS ( ISSUE.renew ) %] + [% ELSE %][% END %] [% END %]
-- 2.39.5