From ec0ea67a43455b94a9d8bd3cf4ba8f68d1678e4a Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Sun, 5 Nov 2017 01:51:39 +0000 Subject: [PATCH] Bug 19581: Remove 'split' option from Catmandu fixes for marc This option in combination with append seems to add null entries in the indexes for fields that don't exist. These fields then affect sorting. Removing it solves the issue To test: 1 - Have an ES setup 2 - Catalog and index some records 3 - View a record in ES: curl 'localhost:9200/koha_kohadev_biblios/data/4?pretty=yes' 4 - Note there are 'null' entries in the indexes, save this result for comparison 5 - Apply patch 6 - Reindex, amking sure to delete existing indexes perl misc/search_tools/rebuild_elastic_search.pl -d 7 - View the record again 8 - Note the null entries are removed 9 - Note indices are otherwise intact Signed-off-by: David Bourgault Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart --- Koha/SearchEngine/Elasticsearch.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm index d859a39362..d904bcf710 100644 --- a/Koha/SearchEngine/Elasticsearch.pm +++ b/Koha/SearchEngine/Elasticsearch.pm @@ -329,7 +329,7 @@ sub get_fixer_rules { # selects a range # The split makes everything into nested arrays, but that's not # really a big deal, ES doesn't mind. - $options = '-split => 1' unless $marc_field =~ m|_/| || $type eq 'sum'; + $options = '' unless $marc_field =~ m|_/| || $type eq 'sum'; push @rules, "marc_map('$marc_field','${name}.\$append', $options)"; if ($facet) { push @rules, "marc_map('$marc_field','${name}__facet.\$append', $options)"; -- 2.39.5