From ecc1f7fb08f29ae0b48f2ed18b6aa4cb3b1f9f5a Mon Sep 17 00:00:00 2001 From: Lari Taskula Date: Mon, 19 Apr 2021 14:54:34 +0000 Subject: [PATCH] Bug 28170: Fix upload.tt search result buttons for page two onwards From https://datatables.net/faqs/index "When attaching events to cells in a table controlled by DataTables, you need to be careful how it is done. Because DataTables removes nodes from the DOM, events applied with a static event listener might not be able to bind themselves to all nodes in the table." Before this patch, there were three non-functional buttons on upload search result page, "+ Choose", "Download" and "Delete". This patch binds the handlers to a static element so that the three buttons in upload.tt on page two onwards are functional again. To test: 1. This test is for the "Download" and "Delete" buttons 1.1. Before applying patch, go to cgi-bin/koha/tools/upload.pl 1.2. Make sure you have at least 21 files uploaded 1.3. Perform a search via "Search term" form so that at least 21 results are returned (e.g. a dot (.) as the search term should return all files with filetype) 1.4. Press "Download" and "Delete" for the first result row, it should work as expected (no need to actually delete the file - as long as it pops up a confirmation, it works as expected) 1.5. Go to page 2 of results 1.6. Press "Download" and "Delete" for the first result in page 2 1.7. Observe nothing happening 1.8. Apply patch 1.9. Repeat steps 3-6 1.10. Observe buttons working as expected 2. This test is for the "+ Choose" button 2.1. Go to cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=856&frameworkcode=#subufield 2.2. Under "Other options (choose one), for "Plugin", select "upload.pl" 2.3. Find a biblio and click Edit Record 2.4. Go to 856$u and click "Upload" 2.5. Repeat steps 1.1. - 1.10., but this time for the "+ Choose" button Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 1b1dbee18fcd0d55065b0758690c0c58296e6029) Signed-off-by: Fridolin Somers (cherry picked from commit 216638e67e1b97405cd67d2842d0774cd6077e42) Signed-off-by: Andrew Fuerste-Henry --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt index 713ae723c7..f4d2debbae 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt @@ -406,17 +406,17 @@ $("#searchbutton").on("click",function(){ return CheckSearch(); }); - $(".choose_entry").on("click",function(e){ + $("#uploadresults tbody").on("click",".choose_entry",function(e){ e.preventDefault(); var record_hashvalue = $(this).data("record-hashvalue"); Choose( record_hashvalue ); }); - $(".download_entry").on("click",function(e){ + $("#uploadresults tbody").on("click",".download_entry",function(e){ e.preventDefault(); var record_id = $(this).data("record-id"); SubmitMe( 'download', record_id ); }); - $(".delete_entry").on("click",function(e){ + $("#uploadresults tbody").on("click",".delete_entry",function(e){ e.preventDefault(); var record_id = $(this).data("record-id"); DeleteEntry( record_id ); -- 2.39.5