From ef2decc48988aa9b622893a7350b9b6b05df79e9 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 5 Feb 2016 09:40:49 +0100 Subject: [PATCH] Bug 14751: [QA Follow-up] Unit tests for interface method Added some descriptions in Context.t and added two tests for sip and commandline. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com --- t/Context.t | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/t/Context.t b/t/Context.t index 8febdb466c..e2c1825270 100755 --- a/t/Context.t +++ b/t/Context.t @@ -2,7 +2,7 @@ use Modern::Perl; use DBI; -use Test::More tests => 24; +use Test::More tests => 26; use Test::MockModule; BEGIN { @@ -49,13 +49,16 @@ is(C4::Context::db_scheme2dbi(), 'mysql', 'ask for nothing, get mysql'); # C4::Context::interface my $lastwarn; local $SIG{__WARN__} = sub { $lastwarn = $_[0] }; -is(C4::Context->interface, 'opac'); -is(C4::Context->interface('foobar'), 'opac'); -like($lastwarn, qr/invalid interface : 'foobar'/); -is(C4::Context->interface, 'opac'); -is(C4::Context->interface('intranet'), 'intranet'); -is(C4::Context->interface, 'intranet'); -is(C4::Context->interface('foobar'), 'intranet'); -is(C4::Context->interface, 'intranet'); -is(C4::Context->interface('OPAC'), 'opac'); -is(C4::Context->interface, 'opac'); +is(C4::Context->interface, 'opac','interface defaults to opac'); +is(C4::Context->interface('foobar'), 'opac', 'interface foobar'); +like($lastwarn, qr/invalid interface : 'foobar'/, 'interface warn on foobar'); +is(C4::Context->interface, 'opac', 'interface still opac'); +is(C4::Context->interface('intranet'), 'intranet', 'interface intranet'); +is(C4::Context->interface, 'intranet', 'interface still intranet'); +is(C4::Context->interface('foobar'), 'intranet', 'interface foobar again'); +is(C4::Context->interface, 'intranet', 'interface still intranet'); +is(C4::Context->interface('OPAC'), 'opac', 'interface OPAC uc'); +is(C4::Context->interface, 'opac', 'interface still opac'); +#Bug 14751 +is( C4::Context->interface( 'SiP' ), 'sip', 'interface SiP' ); +is( C4::Context->interface( 'COMMANDLINE' ), 'commandline', 'interface commandline uc' ); -- 2.39.5