From f1378a537e73c05783082725f203b4cb1eeec596 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 13 May 2019 11:31:14 -0500 Subject: [PATCH] Bug 22898: Add selenium tests placing holds (staff) Quick selenium tests to prevent regressions like bug 22895. Test plan: Make sure the selenium tests return green You can also test the buggy branch: % git checkout v18.11.05 % prove t/db_dependent/selenium/basic_workflow.t => Failure % git bz apply 22895. % prove t/db_dependent/selenium/basic_workflow.t => Success Signed-off-by: Victor Grousset Signed-off-by: Martin Renvoize --- t/db_dependent/selenium/basic_workflow.t | 36 ++++++++++++++++++------ 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t index 5fbe949e58..4883ef98df 100644 --- a/t/db_dependent/selenium/basic_workflow.t +++ b/t/db_dependent/selenium/basic_workflow.t @@ -40,7 +40,7 @@ use C4::Biblio qw( AddBiblio ); # We shouldn't use it use Koha::CirculationRules; -use Test::More tests => 20; +use Test::More tests => 22; use MARC::Record; use MARC::Field; @@ -77,6 +77,9 @@ our $sample_data = { issuelength => '5', lengthunit => 'days', renewalperiod => '5', + reservesallowed => '5', + onshelfholds => '1', + opacitemholds => 'Y', }, }; our ( $borrowernumber, $start, $prev_time, $cleanup_needed ); @@ -85,7 +88,7 @@ $dbh->do(q|INSERT INTO itemtypes(itemtype) VALUES (?)|, undef, $sample_data->{it SKIP: { eval { require Selenium::Remote::Driver; }; - skip "Selenium::Remote::Driver is needed for selenium tests.", 20 if $@; + skip "Selenium::Remote::Driver is needed for selenium tests.", 22 if $@; $cleanup_needed = 1; @@ -155,12 +158,16 @@ SKIP: { categorycode => $issuing_rules->{categorycode}, itemtype => $issuing_rules->{itemtype}, branchcode => $issuing_rules->{branchcode}, - rules => { - maxissueqty => $issuing_rules->{maxissueqty}, - issuelength => $issuing_rules->{issuelength}, - lengthunit => $issuing_rules->{lengthunit}, - renewalperiod => $issuing_rules->{renewalperiod}, - } + rules => { + maxissueqty => $issuing_rules->{maxissueqty}, + issuelength => $issuing_rules->{issuelength}, + lengthunit => $issuing_rules->{lengthunit}, + renewalperiod => $issuing_rules->{renewalperiod}, + reservesallowed => $issuing_rules->{reservesallowed}, + onshelfholds => $issuing_rules->{onshelfholds}, + opacitemholds => $issuing_rules->{opacitemholds}, + + } } ); @@ -227,6 +234,19 @@ SKIP: { time_diff("checkin"); + #Place holds + $driver->get($base_url."/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=".$biblionumbers[0]); + $driver->find_element('//form[@id="hold-request-form"]//input[@type="submit"]')->click; # Biblio level + my $patron = Koha::Patrons->find($borrowernumber); + is( $patron->holds->count, 1, ); + + $driver->get($base_url."/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=".$biblionumbers[1]); + $driver->find_element('//form[@id="hold-request-form"]//input[@type="radio"]')->click; # Item level, there is only 1 item per bib so we are safe + $driver->find_element('//form[@id="hold-request-form"]//input[@type="submit"]')->click; + is( $patron->holds->count, 2, ); + + time_diff("holds"); + close $fh; $driver->quit(); }; -- 2.39.5