From f5121183d9049a82645797e18028d600e11a2476 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 27 Jul 2018 09:42:06 +0200 Subject: [PATCH] Bug 21048: (QA follow-up) Fix authorized value statuses in filter If you select an authorized value status in the filter, you want to keep it too just like normal statuses as CHECKED. The variable selected_status was not filled. The minimal fix is adding that template variable in the script. Note that suggestion.STATUS is out of scope within a loop using suggestion as loop var. Note: Adding a regular status like CHECKED as an authorized value with same code but another description works, but is kind of confusing ;) Not in the scope of this report though. Test plan: Select an authval status in the filter. Apply the filter and verify again that it is still selected under Suggestion information. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit b1e8193a84a8df6d70ad8de16dadb8c4301a706b) Signed-off-by: Martin Renvoize --- suggestion/suggestion.pl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index 98fcca4914..1f6b74e9b8 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -353,7 +353,12 @@ foreach my $budget ( @{$budgets} ) { } $template->param( budgetsloop => \@budgets_loop); -$template->param( "statusselected_$$suggestion_ref{'STATUS'}" =>1) if ($$suggestion_ref{'STATUS'}); +if( $suggestion_ref->{STATUS} ) { + $template->param( + "statusselected_".$suggestion_ref->{STATUS} => 1, + selected_status => $suggestion_ref->{STATUS}, # We need template var selected_status in the second part of the template where template var suggestion.STATUS is out of scope + ); +} my @currencies = Koha::Acquisition::Currencies->search; $template->param( -- 2.39.5