From f8f890621e8ce99c36f4117eb018bbb3ec3da960 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 18 May 2020 17:50:11 +0200 Subject: [PATCH] Bug 25531: Debar patron if needed when checkin is backdated If think this case does not apply to real-life, but the logic needs to be fixed. If an item is due now, and AddReturn is called now with a return date in the future, the issue is overdue and the patron must be debarred. However it is not as we compare with now and not the return date Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 5f48cfc288..e439250933 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2053,7 +2053,7 @@ sub AddReturn { my $fix = _FixOverduesOnReturn( $borrowernumber, $item->itemnumber, $exemptfine, 'RETURNED' ); defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $item->itemnumber...) failed!"; # zero is OK, check defined - if ( $issue and $issue->is_overdue ) { + if ( $issue and $issue->is_overdue($return_date) ) { # fix fine days my ($debardate,$reminder) = _debar_user_on_return( $patron_unblessed, $item->unblessed, dt_from_string($issue->date_due), $return_date ); if ($reminder){ -- 2.39.5