From ff77bb2e8303779208eb2cd34e51d9154b7aa0d4 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Tue, 2 Jul 2019 15:57:09 +0200 Subject: [PATCH] Bug 23252: Add missing input_marceditor class in item editor In serials receive and acquisition order creation from iso2709, the item edition form shows inputs that are missing "input_marceditor" class. They are also missing tabindex and id. The side effect is that those inputs dont get the "noEnterSubmit" class so form is posted if a barcode scanner is used or if enter is used on keyboard. Test plan : 1) 1.1) Verify you have an item subfield linked to items.itemnotes, ie 952$z 1.2) Verify system preference "AcqCreateItem" is on "placing an order" 2) 2.2) Go to cataloguing module and edit an item 2.3) Verify that $z has an id, tabindex and "input_marceditor" class. 2.4) Verify that typing enter in $z does not submit the form 3) 3.1) Go to a serial with items creation, click on receive 3.2) Change status to "Arrived" 3.3) Verify that $z has an id, tabindex and "input_marceditor" class. 3.4) Verify that typing enter in $z does not submit the form 4) 4.1) Go to an acquisition basket 4.2) Click "Add to basket" and "From a staged file" 4.3) Click "Add orders" on a staged file 4.4) Go in tab "Item information" 4.5) Verify that $z has an id, tabindex and "input_marceditor" class. Signed-off-by: Kyle M Hall Signed-off-by: Bouzid Fergani Signed-off-by: Martin Renvoize (cherry picked from commit c855b1ca287758b535fe5ba885949accac4e474a) Signed-off-by: Fridolin Somers --- C4/Items.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Items.pm b/C4/Items.pm index 15b61f0005..05612665fe 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -2556,7 +2556,7 @@ sub PrepareItemrecordDisplay { # oversize field (textarea) $subfield_data{marc_value} = qq(\n"); } else { - $subfield_data{marc_value} = ""; + $subfield_data{marc_value} = qq(); } push( @loop_data, \%subfield_data ); } -- 2.39.5