Kyle M Hall [Tue, 27 Mar 2012 16:01:33 +0000 (12:01 -0400)]
Bug 7485 - Cannot edit barcode on Fast Add
Simple fix, a special case was added for the fast add framework
in the case that an item was being checked out that had not been
catalogued. In that case, the barcode was being passed as a parameter
through addbiblio.pl to additem.pl.
This barcode param was used to overwrite the existing value, so if
no barcode param was passed ( which is only the case with fast adds
from the circ screen ), the barcode field would appear empty in the
items editor.
This commit causes that special case code to check for an existing
barcode value first, and only use the cgi parameter 'branch' in the
case that there is no existing barcode value.
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Editing barcode of fast added item now works. Passes t xt
Recommend this for 3.6 release.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Magnus Enger [Tue, 20 Mar 2012 12:45:48 +0000 (13:45 +0100)]
Bug 7695 - Change boolean operator from "and" to "AND"
When XSLTDetailsDisplay/OPACXSLTDetailsDisplay = on and
TraceSubjectSubdivisions = Include, subject sudivisions are
combined with the boolean operator "and". Currently, this word is
translated along with other occurrences of the same word, resulting
in a false "no records found" for users of non-English templates.
This patch replaces "and" with "AND" which should have no effect on
searching (since Zebra is case-insensitive in this regard) but will
make the boolean operator stand out from other uses of "and" in
translations.
TraceSubjectSubdivisions is currently only implemented in MARC21,
so UNIMARC and NORMARC is not affected.
To test:
XSLTDetailsDisplay/OPACXSLTDetailsDisplay = using XSLT
TraceSubjectSubdivisions = Include
marcflavour = MARC21
Find a record with a clickable subject that includes one or more
subdivisions and check that the subdivisions are combined with
"AND", not "and". Check that you get the expected result when
clicking on the subject.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Easy to test and works as advertised.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Fix installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql so it
includes column names.
To test:
- Install the nb-NO language
- Run through the web installer, and make sure to select the optional
("Valgfritt") z3950servers.sql file
- Check there are no errors
- Check that the Z39.50 errors are displayed OK in
Home › Administration › Z39.50 Servers
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Web installer runs without any errors now and I checked that
the Z39.50 servers were imported correctly and can be edited.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
With marcflavour = NORMARC and OPACXSLTDetailsDisplay = Using XSLT,
the detail view displays a double set of tabs for Normal/MARC/ISBD
views, one above the title and one below.
To test:
marcflavour = NORMARC
OPACXSLTDetailsDisplay = Using XSLT
Since the contents of the recaords do not matter here, the patch
can be tested on MARC records of any flavour.
- Check that double tabs are shown
- Apply the patch
- Check that only the set of tabs at the top is shown
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Wed, 28 Mar 2012 14:17:45 +0000 (16:17 +0200)]
Bug 5354 follow-up : dealing with a wrong regexp
I could not reproduce the working behaviour when I found that the tiny follow-up introduced a bug
| being a reserved char in regexp, split '|' is not splitting on '|' ! we must write '\|' !
Jonathan Druart [Thu, 8 Mar 2012 09:45:32 +0000 (10:45 +0100)]
Bug 5354: Partial duplication of a subscription
A new syspref (SubscriptionDuplicateDroppedInput) contains the list of fields to
duplicate when duplicating a subscription. The library will be able to
define that, for example, the internal note should not be duplicated
Test plan:
On the detail subscription page, click Edit > Edit as New (Duplicate):
All the information must be copied from the original subscription.
Fill the syspref SubscriptionDuplicateDroppedInput with a list of fields
you don't want to be duplicated (e.g. location;notes;branchcode).
Repeat the duplicate action. Normally, information for these fields are
not copied.
Bug 7451 - PrepareItemrecordDisplay missing $subfield_data{id} which breaks AJAX value_builders
In current version of code, it gets initialized too late, so it produces
unitialized warnings for hidden fields (which is non-fatal) and breaks
generated JavaScript for AJAX value_builders (which is fatal)
This bug was introduced in ticket 6106 which is modification of 5955
which didn't have this particular problem.
Since then, this code moved to C4::Items because of de-nesting patches.
Test scenario:
1. define 952$i plugin: stocknumberam123.pl (this is ajax value_builder)
2. go to one of following pages and verify that plugin works:
acqui/addorderiso2709.pl
acqui/neworderempty.pl
acqui/orderreceive.pl
serials/serials-edit.pl
For stocknumberam123.pl plugin to work, you have to have at least
one item with stocknumber in format which this plugin expects:
capital letters, space, some number
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, thanks for the great test plan.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Marcel de Rooy [Wed, 21 Mar 2012 15:29:57 +0000 (16:29 +0100)]
Bug 7783: Show private shelves in opac when deleting non-empty private list from shelf view Signed-off-by: Mathilde Formery <mathilde.formery@ville-nimes.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Bug 7702: [SIGNED-OFF] MARC21 heading tests should not run under UNIMARC
Skip the MARC21-specific tests in t/Heading_MARC21.t if the marcflavour is
UNIMARC.
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I set marcflavour = UNIMARC for testing this.
Before the patch, t/Heading_MARC21.t fails. After the patch it
succeeds.
Signed-off-by: Magnus Enger <magnus@enger.priv.no> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Jonathan Druart [Fri, 2 Mar 2012 12:59:44 +0000 (13:59 +0100)]
Bug 7470: Babeltheque integration
3 features:
- adds social network information in search results
- adds babeltheque data in opac-detail
- adds social network links in opac-detail too (google+, twitter, mail
and co.)
Julian Maurice [Thu, 19 Jan 2012 15:59:58 +0000 (16:59 +0100)]
Bug 7178: Acquisition item creation improvement
- Display a unique item block at once
On orderreceive.pl when AcqCreateItem is 'receiving', and on
neworderempty.pl when AcqCreateItem is 'ordering' it displays an
item block with item infos to fill, and a '+' button.
When user clicks on '+', the block is hidden and a list shows up with
the items that will be received. User can then edit or delete items in
the list and click 'Save' to receive items.
- PrepareItemrecordDisplay is now used for cloning block
Previous cloning function was duplicating ids, the side effect is that
plugins didn't work when several items were displayed.
PrepareItemrecordDisplay regenerate the form with new ids
- New system preference UniqueItemFields
Contains a space-separated list of sql column names (of items table).
This syspref is used in two ways:
- Values corresponding to fields in syspref are not duplicated when
adding a new item (button 'Add')
- When saving the form, a check is made on fields in syspref for
detecting duplicate (in DB and in the form)
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests done are noted on the bug report.
2012-03-23: Fixed conflict in updatedatabase. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Paul Poulain [Wed, 21 Mar 2012 15:18:29 +0000 (16:18 +0100)]
Bug 7780: make silent/verbose flag for translation installing
This patch deal with the -v flag that you can put on translate script.
If you run without -v, the process should be silent
if you run with -v, the process should be verbose
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I've refactored your patch to handle verbosity directly via a translator
attribute, rather than with parameter which has to be send to each object call
method.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Tue, 20 Mar 2012 17:00:32 +0000 (18:00 +0100)]
Bug 7760: Add unique ids and a module class to all administration pages
This is the first patch for bug 7760 and touches all pages in administration.
This adds a unique id "admin_<filename>" and a class "admin" to the body tag of
each page in administration.
Note: aqcontract can only be accessed from the acquisition module, so I made it acq
instead of admin.
Katrin Fischer [Tue, 20 Mar 2012 16:02:41 +0000 (17:02 +0100)]
Bug 7760: Add unique ids and a module class to all authorities pages
This is the first patch for bug 7760 and touches all pages in authorities.
This adds a unique id "auth_<filename>" and a class "auth" to the body tag of
each page in the authorities module.
Katrin Fischer [Tue, 20 Mar 2012 15:41:17 +0000 (16:41 +0100)]
Bug 7760: Add unique ids and a module class to all acquisitions pages
This is the first patch for bug 7760 and touches all pages in acquisitions.
This adds a unique id "acq_<filename>" and a class "acq" to the body tag of
each page in acquisitions.
Frédéric Demians [Fri, 24 Feb 2012 07:50:16 +0000 (08:50 +0100)]
SIGNED-OFF Bug 7590 Cataloging authorities search result page is broken
This bug occurs on UNIMARC DB with authorities linked together with TS/TG
relations. To reproduce it:
- Add a new biblio record
- On 610 field, click on the tag editor button to search an authority
- In the Authority search window, enter a large search
- On the result page, for authorities having relations with other terms, in the
Get it! column, you get a mess of TS/TG relations and not more Choose link.
Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Adrien Saurat [Tue, 20 Mar 2012 12:56:56 +0000 (13:56 +0100)]
Bug 6125: repairs dateaccessioned plugin
1/ It now works with neworderempty.pl
2/ The set_to_today function was moved from
additem.tt to dateaccessioned.pl (so it's
available to all pages using the plugin)
Signed-off-by: Julien Sicot <julien.sicot@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Katrin Fischer [Tue, 20 Mar 2012 14:39:46 +0000 (15:39 +0100)]
Bug 5482: Update colums.def file
Updates the borrowers and items table descriptions using the
descriptions from the interface and the MARC21 default framework.
Biblio and biblioitems still need some work.
Jonathan Druart [Wed, 14 Mar 2012 13:34:27 +0000 (14:34 +0100)]
Bug 5180: FIX autocomplete on overdues report
- Switch off the CircAutocompl syspref
- Set a (one or more) patron attr type searchable
- go on the overdues page
Firebug crash and a layout problem appears on the left.
Firebug error is "YAHOO.widget.DS_XHR is not a constructor"
retry with this patch.
Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Marcel de Rooy [Mon, 19 Mar 2012 13:11:35 +0000 (14:11 +0100)]
Bug 7732: Restoring "More lists" in the Add-to combo of OPAC Search Results
1) More lists -> More Lists in order to be consistent with context.
2) More Lists is put just before New List at the end of the combo list. (More logical place than between your and public lists.)
3) More Lists is only shown when the number of private or public lists exceeds 9; this is a pragmatic and hard-coded approach for now. Only if there are exactly 10 lists, this does not really add a list. But who cares about that?
4) Resolves a potential bug with an [% END %] at the wrong place. Moved it after the finishing optgroup tag.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Performed a search in the OPAC without the patch and More Lists does
not appear. Applied patch and perfomred OPAC search again and the More
Lists option reappears. Signed off.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Adrien Saurat [Wed, 21 Mar 2012 14:29:50 +0000 (15:29 +0100)]
Bug 7778: fixes creation of a new server
It is now possible to add a new server
The page also now complies with the bug 2505 request
(use warnings has been added, and variables declarations
corrected to prevent warnings)
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works perfectly, tested adding, editing and deleting z39.50 servers.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Julian Maurice [Tue, 19 Jul 2011 10:14:00 +0000 (12:14 +0200)]
Bug 7745: Wrong service name for CAS authentification
When behind a proxy, Koha give a wrong service name to CAS server
(SCRIPT_URI environment variable). It now uses OPACBaseURL syspref.
Note: despite the OPACBaseURL description, you have to enter the
*full* URL (ie: with http:// or https://) in the syspref. (see Bug
7770) Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
projects / koha.git / log