From 36a1b9e4dff208b6b55ea50008984c7ca0fb298f Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 17 Nov 2021 18:03:00 -0300 Subject: [PATCH] Bug 29510: Make objects.find call search_limited if present This patch makes objects.find implicitly update the passed *$result_set* to use search_limited. This way no object leaks could happen without noticing. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => FAIL: Tests fail because search_limited is not used 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Results are correctly filtered based on userenv! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy (cherry picked from commit 1f1f0837cd2058ff8e953e6ae719c7513ad35927) Signed-off-by: Fridolin Somers --- Koha/REST/Plugin/Objects.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Koha/REST/Plugin/Objects.pm b/Koha/REST/Plugin/Objects.pm index 32dab06d4b..2777aa076e 100644 --- a/Koha/REST/Plugin/Objects.pm +++ b/Koha/REST/Plugin/Objects.pm @@ -86,6 +86,9 @@ The result object can then be used for further processing. } ); + $result_set = $result_set->search_limited + if $result_set->can('search_limited'); + my $object = $result_set->find( $id, $attributes ); return $object; -- 2.39.5