From 63b6ef7cb7013ddc151c23d5229deb95148dc879 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 10 Aug 2018 12:17:45 -0300 Subject: [PATCH] Bug 21203: ILS-DI - Make GetRecords handle non-existent records Caused by commit cb336e633bf7e0cb25051a8ed8157af8486a58d7 Bug 18255: Koha::Biblio - Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem Can't call method "biblioitem" on an undefined value at /home/vagrant/kohaclone/C4/ILSDI/Services.pm line 212 Test plan: - Enable ilsdi - hit /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=X With X an existing biblionumber and a non existing one Both requests must succeed Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens (cherry picked from commit 88d3865168a83aa7e69999ab3336b238a2ed14ff) Signed-off-by: Martin Renvoize --- C4/ILSDI/Services.pm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm index 5534d3ccbc..9498a77db0 100644 --- a/C4/ILSDI/Services.pm +++ b/C4/ILSDI/Services.pm @@ -209,14 +209,13 @@ sub GetRecords { # Get the biblioitem from the biblionumber my $biblio = Koha::Biblios->find( $biblionumber ); - my $biblioitem = $biblio->biblioitem; - if ( $biblioitem ) { - $biblioitem = $biblioitem->unblessed; - } else { - $biblioitem->{code} = "RecordNotFound"; - # FIXME We should not need to process something else; next? + unless ( $biblio ) { + push @records, { code => "RecordNotFound" }; + next; } + my $biblioitem = $biblio->biblioitem->unblessed; + my $embed_items = 1; my $record = GetMarcBiblio({ biblionumber => $biblionumber, -- 2.39.5