From 6533f32c3a7acdaaa6769e6039472045add847e2 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 26 Feb 2019 11:04:08 -0500 Subject: [PATCH] Revert "Bug 22026: Removed 'use Modern::Perl;' from Koha::REST::classes" This causes test failures in D8 and would require packaging our own perlcritic Reverting until future date when consequences do not outweigh benefits This reverts commit ecc94da6b258e423799e58558a5b02c8f2fcefec. Signed-off-by: Nick Clemens --- Koha/REST/Plugin/Objects.pm | 2 ++ Koha/REST/Plugin/Pagination.pm | 2 ++ Koha/REST/Plugin/PluginRoutes.pm | 2 ++ Koha/REST/Plugin/Query.pm | 2 ++ Koha/REST/V1.pm | 2 ++ Koha/REST/V1/Acquisitions/Vendors.pm | 2 ++ Koha/REST/V1/Auth.pm | 2 ++ Koha/REST/V1/Cities.pm | 2 ++ Koha/REST/V1/Hold.pm | 2 ++ Koha/REST/V1/Illrequests.pm | 2 ++ Koha/REST/V1/OAuth.pm | 2 ++ Koha/REST/V1/Patrons.pm | 2 ++ Koha/REST/V1/Patrons/Account.pm | 2 ++ Koha/REST/V1/Stage.pm | 2 ++ 14 files changed, 28 insertions(+) diff --git a/Koha/REST/Plugin/Objects.pm b/Koha/REST/Plugin/Objects.pm index 931c647f89..3653f914ef 100644 --- a/Koha/REST/Plugin/Objects.pm +++ b/Koha/REST/Plugin/Objects.pm @@ -15,6 +15,8 @@ package Koha::REST::Plugin::Objects; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Plugin'; =head1 NAME diff --git a/Koha/REST/Plugin/Pagination.pm b/Koha/REST/Plugin/Pagination.pm index 47c7fc08a4..02560055f0 100644 --- a/Koha/REST/Plugin/Pagination.pm +++ b/Koha/REST/Plugin/Pagination.pm @@ -15,6 +15,8 @@ package Koha::REST::Plugin::Pagination; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Plugin'; =head1 NAME diff --git a/Koha/REST/Plugin/PluginRoutes.pm b/Koha/REST/Plugin/PluginRoutes.pm index 17ccab38c3..f51c7bdb46 100644 --- a/Koha/REST/Plugin/PluginRoutes.pm +++ b/Koha/REST/Plugin/PluginRoutes.pm @@ -15,6 +15,8 @@ package Koha::REST::Plugin::PluginRoutes; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Plugin'; use Koha::Exceptions::Plugin; diff --git a/Koha/REST/Plugin/Query.pm b/Koha/REST/Plugin/Query.pm index 21479f8d01..090f02fe0b 100644 --- a/Koha/REST/Plugin/Query.pm +++ b/Koha/REST/Plugin/Query.pm @@ -15,6 +15,8 @@ package Koha::REST::Plugin::Query; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Plugin'; use Koha::Exceptions; diff --git a/Koha/REST/V1.pm b/Koha/REST/V1.pm index df327e9c55..b1f4657d4a 100644 --- a/Koha/REST/V1.pm +++ b/Koha/REST/V1.pm @@ -15,6 +15,8 @@ package Koha::REST::V1; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious'; use C4::Context; diff --git a/Koha/REST/V1/Acquisitions/Vendors.pm b/Koha/REST/V1/Acquisitions/Vendors.pm index 79f401f65a..5f86ac82d4 100644 --- a/Koha/REST/V1/Acquisitions/Vendors.pm +++ b/Koha/REST/V1/Acquisitions/Vendors.pm @@ -15,6 +15,8 @@ package Koha::REST::V1::Acquisitions::Vendors; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Controller'; use Koha::Acquisition::Booksellers; diff --git a/Koha/REST/V1/Auth.pm b/Koha/REST/V1/Auth.pm index 0dbd9c8475..92cafc22f2 100644 --- a/Koha/REST/V1/Auth.pm +++ b/Koha/REST/V1/Auth.pm @@ -17,6 +17,8 @@ package Koha::REST::V1::Auth; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Controller'; use C4::Auth qw( check_cookie_auth checkpw_internal get_session haspermission ); diff --git a/Koha/REST/V1/Cities.pm b/Koha/REST/V1/Cities.pm index 8bca97cc65..5a579b4ee4 100644 --- a/Koha/REST/V1/Cities.pm +++ b/Koha/REST/V1/Cities.pm @@ -15,6 +15,8 @@ package Koha::REST::V1::Cities; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Controller'; use Koha::Cities; diff --git a/Koha/REST/V1/Hold.pm b/Koha/REST/V1/Hold.pm index bc25750c0f..c3cb926e78 100644 --- a/Koha/REST/V1/Hold.pm +++ b/Koha/REST/V1/Hold.pm @@ -15,6 +15,8 @@ package Koha::REST::V1::Hold; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Controller'; use C4::Biblio; diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm index 94ff8ce18f..2e428f7527 100644 --- a/Koha/REST/V1/Illrequests.pm +++ b/Koha/REST/V1/Illrequests.pm @@ -15,6 +15,8 @@ package Koha::REST::V1::Illrequests; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Controller'; use Koha::Illrequests; diff --git a/Koha/REST/V1/OAuth.pm b/Koha/REST/V1/OAuth.pm index e7c8ec7a70..b75c89243c 100644 --- a/Koha/REST/V1/OAuth.pm +++ b/Koha/REST/V1/OAuth.pm @@ -15,6 +15,8 @@ package Koha::REST::V1::OAuth; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Module::Load::Conditional; use C4::Context; diff --git a/Koha/REST/V1/Patrons.pm b/Koha/REST/V1/Patrons.pm index 531559644a..5e8e398eac 100644 --- a/Koha/REST/V1/Patrons.pm +++ b/Koha/REST/V1/Patrons.pm @@ -15,6 +15,8 @@ package Koha::REST::V1::Patrons; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Controller'; use Koha::DateUtils; diff --git a/Koha/REST/V1/Patrons/Account.pm b/Koha/REST/V1/Patrons/Account.pm index 3fd3eef398..deb4d3d58c 100644 --- a/Koha/REST/V1/Patrons/Account.pm +++ b/Koha/REST/V1/Patrons/Account.pm @@ -15,6 +15,8 @@ package Koha::REST::V1::Patrons::Account; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Controller'; use Koha::Patrons; diff --git a/Koha/REST/V1/Stage.pm b/Koha/REST/V1/Stage.pm index f439e979dc..485384a41b 100644 --- a/Koha/REST/V1/Stage.pm +++ b/Koha/REST/V1/Stage.pm @@ -15,6 +15,8 @@ package Koha::REST::V1::Stage; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; + use Mojo::Base 'Mojolicious::Controller'; use Koha::StockRotationRotas; -- 2.39.5