]> git.koha-community.org Git - koha.git/commit
Bug 18976: Fix t/db_dependent/Auth.t cleanup
authorLari Taskula <lari.taskula@jns.fi>
Mon, 24 Jul 2017 13:43:18 +0000 (16:43 +0300)
committerMason James <mtj@kohaaloha.com>
Wed, 23 Aug 2017 10:22:38 +0000 (22:22 +1200)
commit13c3f47a362bee89ddff6cc542cdd0bf5e98d455
treed65f1e3b7d8767edbe3a173b88b1627921627596
parenta92f955f4345f0250ba7bfca349a228590d5169c
Bug 18976: Fix t/db_dependent/Auth.t cleanup

Test t/db_dependent/Auth.t seems to have an ineffective test data cleanup.
Data generated by TestBuilder is left in borrowers, branches, categories,
sms_providers and sessions tables after the test.

To replicate:
1. Check the row count of borrowers, branches and categories tables
2. prove t/db_dependent/Auth.t
3. Repeat step 1
4. Observe borrowers the following tables have increased in row count:
   - borrowers
   - branches
   - categories
   - sessions
   - sms_providers

To test:
1. Before applying the patch, go through steps at "To replicate" plan
2. Apply patch
3. Go through steps at "To replicate" plan
4. Observe step 4 no longer applies and those tables have the same number of
   rows as before executing the test.

This issue has been happening in REST tests as well, and this solution is
directly copy-pasted from t/db_dependent/api/v1/cities.t

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Mason James <mtj@kohaaloha.com>
t/db_dependent/Auth.t