]> git.koha-community.org Git - koha.git/commit
Bug 18607: Adjusting unit tests for monthly serial frequencies
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 29 May 2017 10:08:40 +0000 (12:08 +0200)
committerMason James <mtj@kohaaloha.com>
Sun, 30 Jul 2017 13:02:07 +0000 (01:02 +1200)
commit47d9fc52b98b82841ea20353da9d8408e4818397
treea96986ba0e5fcb7de4acacc0ba8c35b58da416c9
parent6ab7280ba2deb50b8f27bc7ddef15e1fcdddaebc
Bug 18607: Adjusting unit tests for monthly serial frequencies

The changes in the first patch require some corrections as well as
additional test cases.

GetNextDate.t: Since the calculation for multiple issues per unit has
slightly changed, a few dates (day 15 or day 16) have been changed in the
unit test; when we use 2/month, the algorithm now always adds 15 days.
Added a few test descriptions in this regard too.

GetFictiveIssueNumber.t: Add the monthly subtest with two test cases. In
the first case we tests multiple units per issue, and in the second case
we test multiple issues per unit (month).

Test plan:
[1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t
[2] Run t/db_dependent/Serials/GetNextDate.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
t/db_dependent/Serials/GetFictiveIssueNumber.t
t/db_dependent/Serials/GetNextDate.t