]> git.koha-community.org Git - koha.git/commit
Bug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl
authorIndranil Das Gupta <indradg@gmail.com>
Thu, 14 May 2015 01:53:16 +0000 (07:23 +0530)
committerLiz Rea <wizzyrea@gmail.com>
Sun, 7 Jun 2015 22:24:27 +0000 (10:24 +1200)
commit5e48a461dbcd102ebc76c7552ed5b695861d97f7
treecda2d577826175fc73213a0afae2baefa619fd10
parent2d2de7b2b3c69732617d1c8bc9f09d81ceedab13
Bug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl

This is a followup for Bug 14186 that removes the extraneous tab
char on line 470, so that the patch can clear QA tools.

This patch sets $reservedfor to an empty string.

Test plan
=========

1/ in a terminal, run `tail -f ` on your instance's opac-error.log
2/ go to the opac and search from an item that exists on the Koha
   instance.
3/ Select the title (if more than one title is returned) and click on
   'Place hold' link to go to opac-reserve.pl
4/ notice the warning - "opac-reserve.pl: Use of uninitialized value
   $reservedfor" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-reserve.pl)
7/ page works but the warning in step #4 is no longer thrown up
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 642e6012cd125cbc3aeaca83e1fd2430ce43fdb0)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
opac/opac-reserve.pl