]> git.koha-community.org Git - koha.git/commit
Bug 25940: Check for reserve_id before Dopop
authorLucas Gass <lucas@bywatersolutions.com>
Mon, 6 Jul 2020 20:38:42 +0000 (20:38 +0000)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Thu, 30 Jul 2020 15:17:08 +0000 (03:17 +1200)
commitd8c9583f2fb2c329a0fd8cca43de663c9d8a512f
treec8cc2872b75e67f4162d9408f24d3e13c7ed41aa
parentdb5ae24f887bd10f8b3c5cf3e0cc65e3ae3178d1
Bug 25940: Check for reserve_id before Dopop

TEST PLAN:
1. Have an item belonging to a different branch and check it in.
2. When the modal pops up hit 'Yes, print slip' or 'Print slip' if  AutomaticItemReturn is set to 'don't'
3. The first print dialog should appear with a URL like '/cgi-bin/koha/circ/transfer-slip.pl?transferitem=18&&branchcode=CPL&op=slip'
4. Close that print dialog and you will immediately see another one that says 'No slip template found'.
5. Notice the URL of the second pop-up is:  /cgi-bin/koha/circ/hold-transfer-slip.pl?reserve_id=
6. There is no reserve id so the template is not found.
7. Apply patch
8. Repeat 1-6
9. You should no longer have two print dialogs

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 0ec7ba72861f21c2ce83d3a98446af7db7a3e321)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 25f91e5f431f8a8f06ac3710d776c7ed57d3bd20)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt