]> git.koha-community.org Git - koha.git/log
koha.git
13 years agoBug 3326: Staff results still displayed &
Jared Camins-Esakov [Sat, 26 Mar 2011 09:58:54 +0000 (05:58 -0400)]
Bug 3326: Staff results still displayed &

In certain circumstances, ampersands would not be displayed properly in the
Staff client search results. This patch fixes that by ensuring that all the
doubled ampersands that Zebra inserts in XML indexing mode are replaced by the
correct single ampersand entity.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fa7ca5c8b8b5fdf27fae63fd0ada7fe539651bc2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5817: Follow-up fixing callnum: on staff results
Jared Camins-Esakov [Sat, 26 Mar 2011 15:03:31 +0000 (11:03 -0400)]
Bug 5817: Follow-up fixing callnum: on staff results

This patch changes the call number links on the staff results page so that
searching will work. The underlying problem described by bug 5274 remains an
issue, but this fixes some of the more problematic symptoms.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b853b79001ceefc897eac781a6ebf28e7cc29c85)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3203: ACCTDETAIL notices don't parse branches or borrowers tokens
Ian Walls [Sun, 27 Mar 2011 17:05:48 +0000 (13:05 -0400)]
Bug 3203: ACCTDETAIL notices don't parse branches or borrowers tokens

This patch enables the ACCTDETAIL notices (and any branch-specific derivatives) to use
<<branches.*>> and <<borrowers.*>> tokens

This patch also attempts to send the email from the branch email first, falling back to
KohaAdminEmailAddress if no branch email exists.

To test:

1. Enable AutoEmailOpacUser system preference
2. Add <<branches.*>> tokens to the ACCTDETAIL notice
3. Create a new patron, including:
   a. test email address in the field matching your AutoEmailPrimaryAddress syspref value
   b. username and password (required to send a notice)
   c. any other required fields to save the record
4. Check you inbox.  Notice should send instantly (no need to run process_message_queue.pl)

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1d6f791541686dfa409843f8f5b1624f1be6e8cb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5960 : Itemtype icons not showing correctly in staff search results
Chris Cormack [Mon, 28 Mar 2011 01:13:13 +0000 (21:13 -0400)]
Bug 5960 : Itemtype icons not showing correctly in staff search results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 42f316ae480100572e996a7a4de76b9528db3d23)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5940: Update Patron Help Files
Nicole C. Engard [Thu, 24 Mar 2011 20:27:03 +0000 (16:27 -0400)]
Bug 5940: Update Patron Help Files

This patch updates the help files in the patron area of Koha.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b8f3120bf5f5e7f2da73c213ed74bb003cf5da25)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3098 follow-up: Clean up formatting
Jared Camins-Esakov [Sun, 22 May 2011 21:31:47 +0000 (17:31 -0400)]
Bug 3098 follow-up: Clean up formatting

This patch cleans up the formatting of the 856 display code in
MARC21slim2OPACDetail.xsl. Tabstops are correct, and the OPACURLOpenInNewWindow
syspref check is moved to control the use of a 'target="_blank"' attribute,
rather than having two blocks of almost-identical code.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 009036b53722881f607ed01b5701bd300abd6735)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5883 : Prevent re-encoding the items if they are already in UTF-8 in ModBiblio.
Frédérick Capovilla [Wed, 23 Mar 2011 14:19:57 +0000 (15:19 +0100)]
Bug 5883 : Prevent re-encoding the items if they are already in UTF-8 in ModBiblio.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit cce98a2914c85ce1e1c5563b64a986c880024079)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5902: additem.pl should default to set library
Jared Camins-Esakov [Fri, 18 Mar 2011 00:48:33 +0000 (20:48 -0400)]
Bug 5902: additem.pl should default to set library

This patch makes the additem screen default to selecting the currently set
library. If the library is unset, it will default to the first branch
alphabetically.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d8e239c23e23eb34eb2552cc036b364c869ceec2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5909 : SetUTF8Flag on any incoming data
Henri-Damien LAURENT [Tue, 22 Mar 2011 09:59:52 +0000 (10:59 +0100)]
Bug 5909 : SetUTF8Flag on any incoming data

This prompts NFC normalization on adding record
Therefore, any saved record will be NFC normalized

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6b4512d5c40b552a45fced0f48635af355d55efa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5907 : MT 2538 : Using default authtypecode for authority display
Matthias Meusburger [Tue, 22 Mar 2011 09:13:12 +0000 (10:13 +0100)]
Bug 5907 : MT 2538 : Using default authtypecode for authority display

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2498992447ba36f4af2aea5df2c2b2130cbe95f0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5889: Messages name in english for notifications on public interface.
Sophie Meynieux [Wed, 23 Mar 2011 11:05:27 +0000 (12:05 +0100)]
Bug 5889: Messages name in english for notifications on public interface.

Modification of template to allow multilanguage support. Alsa fixing columns overflow.

BibLibre bug #5939

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5390: OPAC loses library selection
Jared Camins-Esakov [Mon, 21 Mar 2011 21:36:20 +0000 (16:36 -0500)]
Bug 5390: OPAC loses library selection

This patch ensures that the OPAC library selection masthead will always default
to the branch that is currently being searched. This only applies to systems
with multiple branches and OpacAddMastheadLibraryPulldown turned on.

To test: do a search in the OPAC, limiting by branch. The search results will
still have that branch selected in the masthead dropdown.

This patch also fixes bug 5852 and bug 3778.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0a1f05a5a2cbe0bb5665c824c0cbcf1a0851a6fa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5834: Holds link missing when 942$c is not for loan
Katrin Fischer [Sat, 19 Mar 2011 21:14:33 +0000 (17:14 -0400)]
Bug 5834: Holds link missing when 942$c is not for loan

Adds a check for item-level_itypes system preference. Note that this only
applies to the search results screens.

To test:
1) Set item-level_itypes to 'specific item'
2) Create record and set 942$c to an itype that is marked not for loan
3) Create item with itype not marked 'not for loan'
Current behaviour: Holds link is not shown, sys pref setting doesn't matter

After patch: Holds link is shown
- when item-level_itype is 'specific item'
- when item-level_itype is 'biblio record' and 942$c itype is for loan

Holds link is not shown
- when item-level_itype is 'biblio record' and 942$c is not for loan

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e1654e1aa148303fde0d30360f533be26b3029d3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4878 - Command-line tool for getting and setting sysprefs
Jesse Weaver [Fri, 18 Mar 2011 15:10:19 +0000 (16:10 +0100)]
Bug 4878 - Command-line tool for getting and setting sysprefs

New script misc/admin/koha-preferences - Allows getting and setting of
sysprefs one-at-a-time or in bulk. More info:

misc/admin/koha-preferences help

or:

misc/admin/koha-preferences manual

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6ba6b2e148667d7fc1bd382d8f65c06e28768631)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdding 2 more developers to the history 137 now!
Chris Cormack [Mon, 21 Mar 2011 03:42:49 +0000 (16:42 +1300)]
Adding 2 more developers to the history 137 now!
(cherry picked from commit c523ae2d646350996efa9cfc1e6149e1f1fac722)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5862 - Incompatibility in ajax.js with "localName" for Internet Explorer
Salvador Zaragoza Rubio [Fri, 18 Mar 2011 15:07:04 +0000 (11:07 -0400)]
Bug 5862 - Incompatibility in ajax.js with "localName" for Internet Explorer

It has been detected an incompatibility with Internet Explorer in the ajax.js
file that cause a javascript error for this browser that prevents proper
operation.
The error occurs because the "localName" is not supported by Internet Explorer
and returns "undefined".

Bug 5862 - Incompatibility in ajax.js with "localName" for Internet Explorer

Fix error on comma for IE

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0499633a6b27d44bf002bc4d99b82ee63237a001)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5892 : opac-user: minor spelling/html changes
Paul Poulain [Fri, 18 Mar 2011 14:30:05 +0000 (15:30 +0100)]
Bug 5892 : opac-user: minor spelling/html changes

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 01b6e7a6ddfbaaca59215f7a88d8aa1010053217)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5864: link biblio => serials subscription is wrong
Julian Maurice [Fri, 18 Mar 2011 10:15:08 +0000 (10:15 +0000)]
Bug 5864: link biblio => serials subscription is wrong

The GetSubscription function can be called with 3 parameters : title,
issn, biblionumber.
In biblio view (both opac & staff interface), the link to jump from the
biblio to the subscription(s) was done using title.

The result was that for a title like "Science", all subscriptions
containing "science" in the title were linked.
That's too much and that's false.

This commit fixes this problem by calling GetSubscription with
biblionumber only where applicable.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 632277e453fa80797e1cfc9dc32f1d1d8cc089af)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4330 : Fixing copyright and removing unconditional warn chris c mail 2010-12...
Paul Poulain [Tue, 4 Jan 2011 20:28:10 +0000 (21:28 +0100)]
Bug 4330 : Fixing copyright and removing unconditional warn chris c mail 2010-12-16 on patches ML
(cherry picked from commit 528cfd918c2f8f57a392302897977804c5f7e7c8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4330 : fixing copyright mail from chris c 2010-12-16 on patches ML
Paul Poulain [Tue, 4 Jan 2011 20:26:38 +0000 (21:26 +0100)]
Bug 4330 : fixing copyright mail from chris c 2010-12-16 on patches ML
(cherry picked from commit 04869d0fd08c4bad9403f18365d3648ba1410452)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3735: Wrong search results for a few fields in ccl.properties
Marcel de Rooy [Thu, 17 Mar 2011 14:37:59 +0000 (10:37 -0400)]
Bug 3735: Wrong search results for a few fields in ccl.properties

This patch corrects a syntax error in the definition of bath attributes in
ccl.properties. In particular, it adds the search prefixes 'isbn', 'issn',
'name', and 'notes'. In order to make use of this patch, ccl.properties must be
updated.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 975aea1372de1def413ad02330916942e4160533)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5890 Correct Mismatched operator in comparison
Colin Campbell [Thu, 17 Mar 2011 10:34:52 +0000 (10:34 +0000)]
Bug 5890 Correct Mismatched operator in comparison

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7f0a326da5bb347310e60103bd3486b22a495743)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFollow-up fix for Bug 4218 - Staff client detail page doesn't show hold status
Owen Leonard [Wed, 16 Mar 2011 15:40:41 +0000 (10:40 -0500)]
Follow-up fix for Bug 4218 - Staff client detail page doesn't show hold status

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4b1fe1c9c33a4ac0924c96fd1aacf076c4f2fa23)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5879 : Biblio.pm : fix isbd syspref and default location
Paul Poulain [Wed, 16 Mar 2011 11:06:37 +0000 (12:06 +0100)]
Bug 5879 : Biblio.pm : fix isbd syspref and default location

- the systempreference is isbd, not ISBD
- when preparing the ItemRecord (for acq or serials recieving), there was no default value calculated for location. Fixing that

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 620ae78f847ba3c42bcbfd0e0f9a530daa79e65b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5646: Translated sql files break messaging
Katrin Fischer [Tue, 15 Mar 2011 14:03:30 +0000 (15:03 +0100)]
Bug 5646: Translated sql files break messaging

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1411a929360d1ad667b2178b3d42b82996642bfc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5816: XSLT doesn't display enhanced contents
Jared Camins-Esakov [Tue, 15 Mar 2011 07:26:24 +0000 (03:26 -0400)]
Bug 5816: XSLT doesn't display enhanced contents

This patch corrects and standardizes the display of enhanced contents (MARC 505
with ind2='0').

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit de4619b849e4cc6f7bdc821bd52581876a02b7d2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFollow up for Bug 3326: previous fix broke searches when
Jared Camins-Esakov [Wed, 16 Mar 2011 15:09:46 +0000 (15:09 +0000)]
Follow up for Bug 3326: previous fix broke searches when

This fix ensures that searches will still work when -x is not used when
reindexing Zebra.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Magnus Enger <magnus@bibkat.no>
Signed-off-by: Jane Wagner <jwagner@ptfs.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e18ddca9d4a6c741a918be28bb3e2cc3e2b30030)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3595 (partial): Items seen at checkin are not filling holds well
ruth@bywatersolutions.com [Fri, 4 Mar 2011 19:04:43 +0000 (13:04 -0600)]
Bug 3595 (partial): Items seen at checkin are not filling holds well

In Liz's second comment on this bug, she points out that local-only
holds (and also no-holds) items are being used to fill the first hold
in the queue, no matter where located, transitting if necessary.  If
all the items on a biblio are set to no-holds types, this problem
would never arise, as no holds could be *placed*.  But if you have
one or more unlimitedor local-hold items, then holds are getting
filled by the first item to cross a scanner, no matter what.

This patch will check during C4::Reserves::CheckReserves to make sure
that the hold being handed back to AddReturn is actually fillable by
the item just scanned.  One caveat:  If CircControl is set to "the library
you are logged in at", this will cause items checked in at
other-than-their-home-library to fill local holds at the library where
scanned.  This is, however, an edge case!

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 784b9df4f240302d3946089862ca6bf6f33c08a9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3326: Work around Zebra's handling of &amp; entities
Jared Camins-Esakov [Tue, 15 Mar 2011 02:14:19 +0000 (22:14 -0400)]
Bug 3326: Work around Zebra's handling of &amp; entities

When using XSLT mode, the OPAC results display will show "&amp;" instead of "&"
when Zebra is indexing in XML mode. This patch works around this by replacing
"&amp;" with "&" and then extends the previous fix to apply to all occurrences
of "& " instead of just the first.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d52f3680f482a42cc98ad9810c011c8775d9b3ee)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5865 - Labels wrap incorrectly when paper width is greater than height
Chris Nighswonger [Mon, 14 Mar 2011 20:27:17 +0000 (16:27 -0400)]
Bug 5865 - Labels wrap incorrectly when paper width is greater than height

This is due to the incorrect use of string comparators to compare numeric values.
This patch corrects that.

Note: This should be backported to 3.2.x

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5a924cc530658f3ab11cf1a219fd9ba4e602f1e5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.06.000 v3.02.06
Chris Nighswonger [Tue, 22 Mar 2011 03:14:55 +0000 (23:14 -0400)]
Updating Version Number to 3.02.06.000

13 years agoRelease Notes for 3.02.06.000
Chris Nighswonger [Tue, 22 Mar 2011 03:12:40 +0000 (23:12 -0400)]
Release Notes for 3.02.06.000

13 years agoTranslation strings update for 3.2.6
Frédéric Demians [Mon, 21 Mar 2011 20:49:25 +0000 (21:49 +0100)]
Translation strings update for 3.2.6
(cherry picked from commit ea918baa655554d058645cd02b8ea9d363177be4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5693 : Follow up patch, escaping HTML in limit_cgi so "" dont break hrefs
Chris Cormack [Mon, 14 Mar 2011 20:55:06 +0000 (16:55 -0400)]
Bug 5693 : Follow up patch, escaping HTML in limit_cgi so "" dont break hrefs

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9b5e18c4ee05941eab435d83c510d931dde34370)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.05.003
Chris Nighswonger [Mon, 14 Mar 2011 18:07:10 +0000 (14:07 -0400)]
Updating Version Number to 3.02.05.003

13 years agoBug 3670: change 'Item DUE' to 'Item Due' in English dbs
Nicole Engard [Fri, 11 Mar 2011 10:14:49 +0000 (11:14 +0100)]
Bug 3670: change 'Item DUE' to 'Item Due' in English dbs

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 07b9125861c2d57f787f3bd3d598dcbd652b030b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5819 : No toolbar in record view when quotes present in title - fix
Janusz Kaczmarek [Mon, 14 Mar 2011 06:21:47 +0000 (07:21 +0100)]
Bug 5819 : No toolbar in record view when quotes present in title - fix

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Was able to reproduce problem by surrounding 245$a with "".
Patch fixed the problem.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d6e580439be3382af88aed5e3ba9f7e3e8876f0b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug4438/MT5496 budget Exceeds total allocation
Henri-Damien LAURENT [Sun, 13 Mar 2011 19:52:44 +0000 (20:52 +0100)]
bug4438/MT5496 budget Exceeds total allocation

This is a followup :
When editing a budget, the check for the total allocation would take into account the budget itself.
Showing an improper error message
The problem was solved when adding a child budget but not when editing the same budget.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3e297c6cb8e7b6b73b9df2e2ae1ba3dd0bc014e7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5595 : Fixing a security glitch (please always use placeholders or
Chris Cormack [Sun, 13 Mar 2011 07:30:13 +0000 (20:30 +1300)]
Bug 5595 : Fixing a security glitch (please always use placeholders or
dbh->quote and fixing the tests
(cherry picked from commit 8215cc8bad33ff1dd327ac17fbfecd59e6f06989)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdding release dates and 2 new developers
Chris Cormack [Sun, 13 Mar 2011 01:13:33 +0000 (14:13 +1300)]
Adding release dates and 2 new developers
(cherry picked from commit 4b2ccab56871749016bfffabc32fee44c58f7c78)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5736: Fixing some zebra configuration errors in marc21/biblios/record.abs
Marcel de Rooy [Mon, 14 Feb 2011 08:38:52 +0000 (08:38 +0000)]
Bug 5736: Fixing some zebra configuration errors in marc21/biblios/record.abs

Patch adapted for 3.2.X only. Signed in master.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5569: Corrections to addbiblio.tmpl to be able to delete repetable mandatory...
Janusz Kaczmarek [Thu, 10 Mar 2011 15:45:40 +0000 (16:45 +0100)]
Bug 5569: Corrections to addbiblio.tmpl to be able to delete repetable mandatory subfields

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 728b3725df5b48d47693b7b37454c7b6ab4c6110)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4072 Lost items aren't hidden on OPAC result page
Frédéric Demians [Thu, 10 Mar 2011 17:29:11 +0000 (11:29 -0600)]
Bug 4072 Lost items aren't hidden on OPAC result page

When hidelostitems system preference is enabled, lost items are hidden on OPAC
detail page but are shown on result page. This patch modify MARC21/UNIMARC XSL
in order to take into account hidelostitems syspref on OPAC result page.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 326222e3f109d816a8fa3118c068df7a3f706f52)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5846: fix detection of Javascript to compress by mod_gzip
Galen Charlton [Wed, 9 Mar 2011 22:14:56 +0000 (17:14 -0500)]
bug 5846: fix detection of Javascript to compress by mod_gzip

Update to default Apache config; should result in a slight
performance benefit.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 12cc56a9c7f2527e126fc32c920d141cf2fdd034)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5595: (MT #5757)adding additional attributes support on patrons's search
Stéphane Delaune [Tue, 8 Mar 2011 03:34:19 +0000 (22:34 -0500)]
Bug 5595: (MT #5757)adding additional attributes support on patrons's search

Restores ability to search on extended borrower attributes that are configured to be searchable

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0ee0cc18b314d0123d8436a798bb02c5c1448494)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug_5064 Rework data retrieval in booksellers.pl
Colin Campbell [Tue, 8 Mar 2011 02:41:13 +0000 (21:41 -0500)]
bug_5064 Rework data retrieval in booksellers.pl

loops were slightly illogical and db accesss was excessive
and repetitive. caused it not to scale well on large datasets
Routines in Acquisition.pm seem to have inconsistent views
of the data.
rework logic to utilize db and processing better

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0fd3b7f112c419629c3999d830ee04218dc55730)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoupdate INSTALL* to acknowledge the use of mod_deflate
Tomás Cohen Arazi [Fri, 11 Mar 2011 11:05:12 +0000 (12:05 +0100)]
update INSTALL* to acknowledge the use of mod_deflate

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 002baadaf4cde6a397ca93cda35fadd012b40629)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5527: Fix some problems in inactive borrowers report
Katrin Fischer [Mon, 7 Mar 2011 18:50:48 +0000 (13:50 -0500)]
Bug 5527: Fix some problems in inactive borrowers report

- 'Not checked out since:' date was not added to query
- borrowers with only checkouts and no returns since this date were considered inactive

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f2cf6c2db3e126541b10d9c1d9d7458c6766a071)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5703: Hide the $9 subfield (linked authid) when showing series for a MARC record...
Frédérick Capovilla [Mon, 7 Mar 2011 18:18:41 +0000 (13:18 -0500)]
Bug 5703: Hide the $9 subfield (linked authid) when showing series for a MARC record in normal view.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b39466c965dc216680d6ff12d3044e9e5174ea4a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3624 : Follow up patch, to catch any installs that still have the missing columns
Chris Cormack [Fri, 11 Mar 2011 19:15:17 +0000 (08:15 +1300)]
Bug 3624 : Follow up patch, to catch any installs that still have the missing columns

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBZ3624, proposed patch for kohastructure.sql rewritten
Paul Poulain [Mon, 7 Mar 2011 18:12:44 +0000 (13:12 -0500)]
BZ3624, proposed patch for kohastructure.sql rewritten

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 306871578edc592b2b1ff20c19b33d801e2573fc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 2975: whitespace and formatting cleanup
Galen Charlton [Thu, 3 Mar 2011 19:52:47 +0000 (14:52 -0500)]
bug 2975: whitespace and formatting cleanup

Not part of the bugfix per se, but taking this chance
to clean up some inconsistent tabbing.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2e963dc416f533a0acb857f022295da42ceed1ff)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 2975: fix calculation of due dates by offline circ
Galen Charlton [Thu, 3 Mar 2011 19:52:46 +0000 (14:52 -0500)]
bug 2975: fix calculation of due dates by offline circ

Offline circ no longer tries to calculate the due date
directly, instead relying on the AddIssue and AddRenewal
APIs to do so.  This corrects a bug where the due date
would be calculated incorrectly if the item-level_itypes
system preference is turned on.

This change also has the effect of causing the issue date
for loans uploaded via offline circulation to be set
to the time stamp recorded by the offline circulation client.

Test plan:

* Turn on item-level_itypes
* Create an example item whose loan policy per
  the item's item type would be different from
  the default policy based on the bib-level type.
* Create a test KOC file with a loan of the test
  item and the checkout date artificially set
  to yesterday.
* Upload the file:
  - Before the fix, the due date would be set
    to the default due date.  Also, the issue date
    will be set to the date of the upload.
  - After the fix, the due date would be calculated
    correctly based on the item's item type.  Also,
    the issue date will be set to the date recorded
    by the offline circulation client.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 935635aba5dc0ab62f9476986cc418ae8c980b57)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5831: rebuild_zebra.pl doesn't respect -r
Ian Walls [Fri, 4 Mar 2011 20:08:22 +0000 (15:08 -0500)]
Bug 5831: rebuild_zebra.pl doesn't respect -r

Reimplements support for -r, as well for -reset

Signed-off-by: D Ruth Bavousett <ruth@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8dc56a0d2c5f33f6d14e2039c7cad9fa9598f14f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5820: Change language to 'Fund' over 'Budget'
Nicole C. Engard [Thu, 3 Mar 2011 14:17:19 +0000 (09:17 -0500)]
Bug 5820: Change language to 'Fund' over 'Budget'

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d6718e14e7637289db57e80f27dc46be51b0e38f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5693 - mc-ccode parens fix
Reed Wade [Fri, 4 Mar 2011 04:13:00 +0000 (23:13 -0500)]
bug 5693 - mc-ccode parens fix

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c84dad3b187770160a845d77f146870cc0159c63)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years ago(bug #5157) fix borrowers top issues
Nahuel ANGELINETTI [Tue, 1 Mar 2011 20:55:38 +0000 (21:55 +0100)]
(bug #5157) fix borrowers top issues

this fix filters of borrowers top issues that doesn't work really well... perhaps because reports scripts need too much improvment.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6b285cf44d969ccfddf7c208803b1cd679185915)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 4853 - Rights needed to renew a document
Owen Leonard [Tue, 1 Mar 2011 20:19:16 +0000 (21:19 +0100)]
Fix for Bug 4853 - Rights needed to renew a document

Correcting check for circulation permission. Also updating
updateitem.pl (for setting lost and damaged statuses) with
circulate permissions.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7a587112f0417f152b2c95f81cb5e0f82df91c73)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 4290 - search for author in repository
Owen Leonard [Tue, 1 Mar 2011 13:01:32 +0000 (14:01 +0100)]
Fix for Bug 4290 - search for author in repository

Reimplementation of Nahuel's patch from 2010-03-02

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0ba9aab76bdcc16ff00d8888cbf6a8145a329a07)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3341: Fines calculation erroneous when a repeatable holiday is added
Frédérick Capovilla [Sat, 5 Mar 2011 19:15:04 +0000 (08:15 +1300)]
Bug 3341: Fines calculation erroneous when a repeatable holiday is added

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit dbe3780fc0e54e637fcbac96bb758781f722ddc4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFixing a utf8 issue with the translator tests
Chris Cormack [Sat, 5 Mar 2011 19:05:40 +0000 (08:05 +1300)]
Fixing a utf8 issue with the translator tests
(cherry picked from commit 7c97e0bfe7ae18694437e03814b8f61811493593)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5824: Creating a circ rule for a specific library causes anomalies
Ian Walls [Thu, 3 Mar 2011 23:13:26 +0000 (18:13 -0500)]
Bug 5824: Creating a circ rule for a specific library causes anomalies

The variable name for the current branch being edited was the same as the variable used in
cat-search.inc, which passed along the circ-rule library to circulation.pl, and then overriding
the set library from there.

This patch renames the template variable 'current_branch', so that it does not populate the 'branch'
param in cat-search.inc

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4735e296cf99dea4dd5217193460f8585d6cf25d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5818, Date picker broken on label batches
Owen Leonard [Thu, 3 Mar 2011 22:20:40 +0000 (17:20 -0500)]
Fix for Bug 5818, Date picker broken on label batches

Calendar picker JS can't come before main JS includes

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2dde87679864042fb531c3f580e564a3d6b70f3b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFixing license and copyright statement for updatedatabase.pl
Chris Cormack [Sat, 5 Mar 2011 07:24:57 +0000 (20:24 +1300)]
Fixing license and copyright statement for updatedatabase.pl
(cherry picked from commit de6b9fc534c1be11aaf1e4e08edf4b5ce26ca9a5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.05.001
Chris Nighswonger [Sun, 6 Mar 2011 00:34:06 +0000 (19:34 -0500)]
Updating Version Number to 3.02.05.001

13 years agoBug 5642: Item field serial enumeration (enumchron) should be longer
Marcel de Rooy [Sun, 27 Feb 2011 08:49:50 +0000 (03:49 -0500)]
Bug 5642: Item field serial enumeration (enumchron) should be longer

Field enumchron in items table is now varchar(80).
We have records that need a much longer field, even up to 400 or 500 chars.
I suggest to change its type to TEXT (variable length with max 64K; tinytext
goes up to 255 chars and is just too short).
Mediumtext or longtext are not needed; as a side note these types are used in
the items table for e.g. booksellerid and more_subfields_xml..

Revised original patch thanks to Ian Walls: update kohatructure.sql. Copied the change in deleteditems as well.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fca88d102b91d3781c10c3d533a0fd942d4bd1f2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5813: Remove unnecessary empty file
MJ Ray [Fri, 25 Feb 2011 13:51:03 +0000 (08:51 -0500)]
bug 5813: Remove unnecessary empty file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f68386f7495e9e1fe990913e90c61173feffdd5e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 4852 - rewrite the query to include limits if using ccl=
Robin Sheat [Thu, 24 Feb 2011 21:33:38 +0000 (16:33 -0500)]
Bug 4852 - rewrite the query to include limits if using ccl=

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 87ec4126484d5c55efd66b359220934d3501ff6c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5792 - Add reference icon to Bridge icon set
Nicole C. Engard [Wed, 23 Feb 2011 13:46:40 +0000 (08:46 -0500)]
Bug 5792 - Add reference icon to Bridge icon set

Signed-off-by: D Ruth Bavousett <ruth@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 19adf162ca1cc34189bb5905daa23d9314f1b58a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5799 make language on circ history consistent
Nicole C. Engard [Wed, 23 Feb 2011 13:46:22 +0000 (08:46 -0500)]
Bug 5799 make language on circ history consistent

Signed-off-by: D Ruth Bavousett <ruth@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bbd08ffd094e8131aafe12f519eb15b225a4c223)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFixing the translatable tests to work in french locales
Chris Cormack [Thu, 3 Mar 2011 23:31:48 +0000 (12:31 +1300)]
Fixing the translatable tests to work in french locales
(cherry picked from commit 24db3d4a44d2d261df449a963881b0e99b90afa4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5814 - Style error message on manage staged records page according to...
Owen Leonard [Mon, 21 Feb 2011 02:33:30 +0000 (21:33 -0500)]
Fix for Bug 5814 - Style error message on manage staged records page according to standard

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6ded7b9897cf8d4d25781f988ad8bb66dbc5a71e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 3319 Followup: Fix compatibility with fix for bug 4945
Ian Walls [Sat, 19 Feb 2011 10:38:32 +0000 (05:38 -0500)]
Bug 3319 Followup: Fix compatibility with fix for bug 4945

The fix for 3319 overwrote the @branchloop variable with output from GetBranchesLoop,
which forces a selected branch.  Removing the extra call, and just measuring the size of
@branchloop as it was build, plus some dereferencing, fixes the issue.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 1953 - Follow up fix on security patch
Marcel de Rooy [Mon, 28 Feb 2011 08:30:07 +0000 (08:30 +0000)]
Bug 1953 - Follow up fix on security patch

Fixing: Undefined subroutine prepare called on line 722.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 439d2224e1215fa876ff7c5a06f773003555a035)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFollow-up fix for Bug 5733 - Empty cart in intranet when session is closed
Owen Leonard [Fri, 11 Feb 2011 06:08:19 +0000 (01:08 -0500)]
Follow-up fix for Bug 5733 - Empty cart in intranet when session is closed

Modifying empty cart function to take a paramter: if true,
cart will be emptied without a prompt.

Removing unnecessary  "javascript:" pseudo-protocol.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 61f6828d123080017b01e322eea19eb3707da428)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5812 - Tag Cloud - capitalized words come before lower-case words
Owen Leonard [Mon, 21 Feb 2011 02:32:22 +0000 (21:32 -0500)]
Fix for Bug 5812 - Tag Cloud - capitalized words come before lower-case words

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit edafbd941d14977cb98d07d2fd3fbba3b2a995ac)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFollow-up fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view
Owen Leonard [Sun, 20 Feb 2011 17:28:30 +0000 (12:28 -0500)]
Follow-up fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view

Fix for Bug 5551 overwrote the necessary changes to opac-detail.pl

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit baec90aae9359709abc9c18f8b2de0f446bf194a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 1953: Reduce risk of possible tainted supplierid call to C4::Serials::GetLateIssues
MJ Ray [Fri, 25 Feb 2011 13:26:20 +0000 (08:26 -0500)]
bug 1953: Reduce risk of possible tainted supplierid call to C4::Serials::GetLateIssues

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 74cdd57ecb28a3f6b443c70274528c1ae5daf352)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years ago2742 Encoding problem
Marcel de Rooy [Wed, 23 Feb 2011 12:55:32 +0000 (12:55 +0000)]
2742 Encoding problem

Small correction of e umlaut. [Something happened with encoding of signed patch; my original patch did not show a wrong character.]

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 575a690b4e0e833db54cb1dbfc5da7470c165b17)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.05.000 v3.02.05
Chris Nighswonger [Thu, 24 Feb 2011 20:41:17 +0000 (15:41 -0500)]
Updating Version Number to 3.02.05.000

13 years agoRelease Notes for 3.02.05.000
Chris Nighswonger [Thu, 24 Feb 2011 20:36:36 +0000 (15:36 -0500)]
Release Notes for 3.02.05.000

13 years agoSecurity Bugfix: Bug 1953 Adding Placeholders to SQL To Avoid Potential Injection...
Chris Nighswonger [Thu, 24 Feb 2011 14:57:11 +0000 (09:57 -0500)]
Security Bugfix: Bug 1953 Adding Placeholders to SQL To Avoid Potential Injection Attacks

This patch addresses both security issues mentioned in the summary of the report
submitted by Frère Sébastien Marie included below.

---------------------------
The problem is here: 'C4/AuthoritiesMarc.pm' in the function 'DelAuthority':
The argument $authid is included directly (not via statement) in the SQL.

For the exploit of this problem, you can use 'authorities/authorities-home.pl'
with authid on the URL and op=delete (something like
"authorities/authorities-home.pl?op=delete&authid=xxx").

This should successfully call DelAuthority, without authentification...
(DelAuthority is call BEFORE get_template_and_user, so before authentification
[This should be an issue also...]).

Please note that the problem isn't only that anyone can delete an authority of
this choose, it is more general: with "authid=1%20or%1=1" (after inclusion sql
will be like: "delete from auth_header where authid=1 or 1=1") you delete all
authorities ; with "authid=1;delete%20from%xxx" it is "delete from auth_header
where authid=1;delete from xxx" and so delete what you want...

SQL-INJECTION is very permissive: you can redirect the output in a file (with
some MySQL function), so write thea file of you choose in the server, in order
to create a backdoor, and compromise the server.

Signed-off-by: Frère Sébastien Marie <semarie-koha@latrappe.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b0f60221f41041665c4fecacce35654fc8d45a01)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years ago2742: Wrong language name in the preferences
marcel@libdevelop.rijksmuseum.nl [Mon, 21 Feb 2011 14:40:44 +0000 (15:40 +0100)]
2742: Wrong language name in the preferences

Follow up patch. Improvement suggested by Belgian translators (Hans Supply).

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fc1b7201c55d00d6c43a0ecc04bee09cd0e0bde7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoPartial fix for Bug 5745, Overdues with fines report not showing titles
Owen Leonard [Sat, 12 Feb 2011 03:22:16 +0000 (22:22 -0500)]
Partial fix for Bug 5745, Overdues with fines report not showing titles

- Adding title, subtitle, and author to output
- Reworking display of shelving location selection

Patch does not address the contents of 'overdue status' and 'notified by'

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 50c0ae09a12e10b851022d6b3fe18aa0b345a98b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5759 : displaying 2nd email if there is one on print template for borrowers
Paul Poulain [Tue, 15 Feb 2011 00:52:35 +0000 (13:52 +1300)]
Bug 5759 : displaying 2nd email if there is one on print template for borrowers

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2f9bebf802530ad1a96fe5bb5ced1b8ef02ba46f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5769 - notice tab disappearing on edit patron
Owen Leonard [Thu, 17 Feb 2011 18:32:32 +0000 (13:32 -0500)]
Fix for Bug 5769 - notice tab disappearing on edit patron

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ed2b583eb10cb81c26c43714572bbb2c85d5797c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.04.000 v3.02.04
Chris Nighswonger [Tue, 22 Feb 2011 03:01:52 +0000 (22:01 -0500)]
Updating Version Number to 3.02.04.000

13 years agoRelease Notes for 3.02.04.000
Chris Nighswonger [Tue, 22 Feb 2011 02:59:31 +0000 (21:59 -0500)]
Release Notes for 3.02.04.000

13 years agoTranslation update for 3.2.4
Frédéric Demians [Mon, 21 Feb 2011 17:38:06 +0000 (18:38 +0100)]
Translation update for 3.2.4
(cherry picked from commit 44c2af8d66e2fdb6036469a296238b6da41c880c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoRevert "Partial fix for Bug 5745, Overdues with fines report not showing titles"
Chris Nighswonger [Mon, 21 Feb 2011 19:12:52 +0000 (14:12 -0500)]
Revert "Partial fix for Bug 5745, Overdues with fines report not showing titles"

This reverts commit 65e478ca51a5b20d4b26c31213571f1344c42fbf.

Patch accidentally pushed which  introduces string changes.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoRevert "Bug 5759 : displaying 2nd email if there is one on print template for borrowers"
Chris Nighswonger [Mon, 21 Feb 2011 19:11:48 +0000 (14:11 -0500)]
Revert "Bug 5759 : displaying 2nd email if there is one on print template for borrowers"

This reverts commit 211dae9f01d27b6bcce1ddfd5737862bcaa592bc.

Patch accidentally pushed which introduces string changes.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoRevert "Fix for Bug 5769 - notice tab disappearing on edit patron"
Chris Nighswonger [Mon, 21 Feb 2011 19:09:35 +0000 (14:09 -0500)]
Revert "Fix for Bug 5769 - notice tab disappearing on edit patron"

This reverts commit 31760556526f2cca3082e490384d30324b6deb8b.

Patch accidentally pushed which  introduces string changes.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5776 - menu on funds wraps when only 1 fund
Owen Leonard [Fri, 18 Feb 2011 23:43:08 +0000 (18:43 -0500)]
Fix for Bug 5776 - menu on funds wraps when only 1 fund

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a0367aa973ad61eda090d743cccd9cf387dfcc09)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5741 - Extra comma causes JavaScript error in Internet Explorer
Reed Wade [Tue, 15 Feb 2011 01:00:00 +0000 (14:00 +1300)]
Bug 5741 - Extra comma causes JavaScript error in Internet Explorer

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1f0e0c5de182cde0215ac0782563d89b3d04291b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5777 Update and install syspref tab titles
Frédéric Demians [Sat, 19 Feb 2011 10:55:23 +0000 (11:55 +0100)]
Bug 5777 Update and install syspref tab titles

This allow also Save button label translation

[3.2] It applies

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit eaf4cfe6b8684b1fff6d7fc6b3b93a456f57fda8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoNormalizeString POD Fixing and variable renaming
Paul Poulain [Wed, 15 Dec 2010 19:29:50 +0000 (20:29 +0100)]
NormalizeString POD Fixing and variable renaming

    POD was mistakenly telling that NFD was supposed to be the default
    encoding.  In fact, it is not, it is NFC.
    So the variable $nfc to change to the not default encoding was misleading.
    Renaming it into $nfd

(written by hdl)

Refactored by Chris Cormack

Signed-off-by: Davi <davi@gnu.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4117b293f633597e74e3dda9e1e52810d31ad23d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5769 - notice tab disappearing on edit patron
Owen Leonard [Thu, 17 Feb 2011 18:32:32 +0000 (13:32 -0500)]
Fix for Bug 5769 - notice tab disappearing on edit patron

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ed2b583eb10cb81c26c43714572bbb2c85d5797c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5140 - In Chrome, drop-down menus disappear after using pop-up calendar
Owen Leonard [Sun, 13 Feb 2011 05:44:07 +0000 (00:44 -0500)]
Fix for Bug 5140 - In Chrome, drop-down menus disappear after using pop-up calendar

Disabling that part of the calendar JavaScript which hides
<select> form fields when the calendar is displayed. This is at
the expense of IE6.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fb5ede8b59bb82e00736235e9ada293cc13e67e4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating Version Number to 3.02.03.003
Chris Nighswonger [Mon, 21 Feb 2011 17:34:20 +0000 (12:34 -0500)]
Updating Version Number to 3.02.03.003

13 years agoBug 2742 Followup patch fixing Norwegian bokmål, adding nynorsk
Magnus Enger [Tue, 15 Feb 2011 10:37:06 +0000 (11:37 +0100)]
Bug 2742 Followup patch fixing Norwegian bokmål, adding nynorsk

- Replace Norwegian with Norwegian bokmål
- Add Norwegian nynorsk, which was missing

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5d82c493f76b609df48478219e75d901df80b055)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>