]> git.koha-community.org Git - koha.git/commit
Bug 14937: Expiration date for holds based onReservesMaxPickUpDelay should not requir...
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 1 Oct 2015 16:59:26 +0000 (12:59 -0400)
committerChris Cormack <chris@bigballofwax.co.nz>
Sat, 24 Oct 2015 08:17:05 +0000 (21:17 +1300)
commit77aedf1f7faf1bded9ed4de41d628e2a2fc8ba7d
tree87ee779621f60ada07d5ab6c7dc50dafecd56259
parent7f39c6a00c2647107f2da5b2385567a953113f51
Bug 14937: Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay

C4::Letters::_parseletter will replace reserves.expirationdate with the
date a hold will be marked as problematic ( holds over ) if both
ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled.
There is no reason this feature needs to rely on
ExpireReservesMaxPickUpDelay as there are many libraries that would like
to send the last day to pick up a hold in notices, but would rather deal
with the expired waiting holds manually rather than have Koha cancel
them automatically.

Test Plan:
1) Apply this patch
2) Set ReservesMaxPickUpDelay to 7
3) Disable ExpireReservesMaxPickUpDelay
4) Add reserves.expirationdate to your HOLD notice
5) Fill a hold for a patron
6) View the message, not that reserves.expirationdate is replaced
   with the date the hold will be marked as problematic

Signed-off-by: Karl Holton <kholten@switchinc.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit c6d0202569146f52898363eda621f771b61cc918)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
C4/Letters.pm