From 2ec7d2864f1e25511ca2ff52456adecc3b37f339 Mon Sep 17 00:00:00 2001 From: Aleisha Date: Wed, 24 Jun 2015 01:15:32 +0000 Subject: [PATCH] Bug 14445: Silences warn in letter.pl When changing Koha module to 'Circulation', there is a warn saying that $code is uninitialized. This patch sets $code to an empty string to silence the warn. To test: 1) Go to Tools, the Notices & Slips 2) Click 'new notice' (This will trigger warns, but ignore these as they will be corrected in the next patch) 3) Change Koha module to 'Circulation' 4) Notice warn about uninitialized $code variable 5) Apply patch and reload page, change Koha module to 'Circulation' 6) Notice page still works and warns are gone Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit fe3a49e61133e1e66d0075f3300cd3a99e691890) Signed-off-by: Chris Cormack Signed-off-by: Liz Rea --- tools/letter.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/letter.pl b/tools/letter.pl index df7ea5a71b..d2ac092a0a 100755 --- a/tools/letter.pl +++ b/tools/letter.pl @@ -224,7 +224,7 @@ sub add_form { } - if ( $module eq 'circulation' && $code eq "CHECKIN" ) { + if ( $module eq 'circulation' and $code and $code eq "CHECKIN" ) { push @{$field_selection}, add_fields('old_issues'); } else { push @{$field_selection}, add_fields('issues'); -- 2.39.5