From 6c9d15ba493e0485a11a03adea3cac96cfee94ba Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 8 Mar 2021 15:30:09 +0000 Subject: [PATCH] Bug 27896: Remove DeleteTransfer This patch removes the last mentions of DeleteTransfer Test plan 1/ Grep the codebase for DeleteTransfer 2/ It should no longer exist Signed-off-by: Petro Vashchuk Signed-off-by: Kyle M Hall Bug 27896: (QA follow-up) Fix number of unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart --- C4/Circulation.pm | 19 ------------------- t/db_dependent/Circulation/transfers.t | 9 +-------- 2 files changed, 1 insertion(+), 27 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 0ab20a17f2..2295d40d23 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -120,7 +120,6 @@ BEGIN { &GetTransfers &GetTransfersFromTo &updateWrongTransfer - &DeleteTransfer &IsBranchTransferAllowed &CreateBranchTransferLimit &DeleteBranchTransferLimits @@ -3487,24 +3486,6 @@ sub GetTransfersFromTo { return (@gettransfers); } -=head2 DeleteTransfer - - &DeleteTransfer($itemnumber); - -=cut - -sub DeleteTransfer { - my ($itemnumber) = @_; - return unless $itemnumber; - my $dbh = C4::Context->dbh; - my $sth = $dbh->prepare( - "DELETE FROM branchtransfers - WHERE itemnumber=? - AND datearrived IS NULL " - ); - return $sth->execute($itemnumber); -} - =head2 SendCirculationAlert Send out a C or C alert using the messaging system. diff --git a/t/db_dependent/Circulation/transfers.t b/t/db_dependent/Circulation/transfers.t index c22992d381..5e639ae90c 100755 --- a/t/db_dependent/Circulation/transfers.t +++ b/t/db_dependent/Circulation/transfers.t @@ -27,7 +27,7 @@ use Koha::Item::Transfers; use t::lib::TestBuilder; -use Test::More tests => 25; +use Test::More tests => 22; use Test::Deep; BEGIN { @@ -38,7 +38,6 @@ can_ok( qw( CreateBranchTransferLimit DeleteBranchTransferLimits - DeleteTransfer GetTransfers GetTransfersFromTo ) @@ -223,12 +222,6 @@ is( is(C4::Circulation::DeleteBranchTransferLimits(),undef,"Without parameters DeleteBranchTransferLimit returns undef"); is(C4::Circulation::DeleteBranchTransferLimits('B'),'0E0',"With a wrong id DeleteBranchTransferLimit returns 0E0"); -#Test DeleteTransfer -is( C4::Circulation::DeleteTransfer($item_id1), - 1, "A the item1's transfer has been deleted" ); -is(C4::Circulation::DeleteTransfer(),undef,"Without itemid DeleteTransfer returns undef"); -is(C4::Circulation::DeleteTransfer(-1),'0E0',"with a wrong itemid DeleteTranfer returns 0E0"); - #Test TransferSlip is( C4::Circulation::TransferSlip($branchcode_1, undef, 5, $branchcode_2), undef, "No tranferslip if invalid or undef itemnumber or barcode" ); -- 2.39.5