From a2e89edf43b2946da0986a5c83b04a60dea04061 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 10 Jun 2013 14:05:32 +0200 Subject: [PATCH] Bug 10439: fix bug preventing the library for a notice from being changed 2 javascript functions should be apply only in a specific case, not for all views. Test plan: - Switch on the IndependentBranches pref and log in as a superlibrarian. - Try to change the library for a notice. Before the patch, no change is applied. - Try to create a new notice, changing the library from default in the process. Before the patch, the notice is not created. The bug can also be reproduced when IndependentBranches is off, in which case the staff user need not be a superlibrarian. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Signed-off-by: Galen Charlton (cherry picked from commit 77a5e3e365a50b02c9f224d731e05de90fc667c9) Signed-off-by: Tomas Cohen Arazi Test plan works as advertised. --- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt index f2107159ae..52e2b83220 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt @@ -15,14 +15,16 @@ $(document).ready(function() { ], "bPaginate": false })); - $('#branch').change(function() { + [% IF no_op_set %] + $('#branch').change(function() { $('#op').val(""); $('#selectlibrary').submit(); - }); - $('#newnotice').click(function() { + }); + $('#newnotice').click(function() { $('#op').val("add_form"); return true; - }); + }); + [% END %] }); [% IF ( add_form ) %] -- 2.39.5