From aa3415ff3f18821b786281a1dc611cf86015e1e2 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
Date: Sat, 3 Sep 2022 14:08:50 +0300
Subject: [PATCH] Bug 28012: Creating numbering pattern: mark mandatory fields
 required

If any of these fields were missing, notably the Numbering formula
then saving the new numbering pattern silently failed, it didn't give
any error but it didn't save any new pattern either.

Note that there is a plan to make description field optional, so even
if it currently is mandatory on the DB level we leave it optional
here (and due to people using production DB's in non-strict mode which
allows this to be optional).

To test:
  1) After applying this patch make sure all the 3 fields must be
  filled in
  /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new
  page and it cannot be saved without those.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit a69b5e6ee99478e730be574178c30f950a09532e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 77e7e11c3a0963bef8d0295eca92f49759f1f3ec)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../en/modules/serials/subscription-numberpatterns.tt  | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
index 1d0a60ce75..9d31728609 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt
@@ -69,16 +69,18 @@
             <fieldset class="rows">
               <ol>
                 <li>
-                  <label for="label">Name:</label>
-                  <input type="text" id="label" name="label" value="[% label | html %]" />
+                  <label class="required" for="label">Name:</label>
+                  <input type="text" id="label" name="label" value="[% label | html %]" class="required" required="required" />
+                  <span class="required">Required</span>
                 </li>
                 <li>
                   <label for="description">Description:</label>
                   <input type="text" id="description" name="description" value="[% description | html %]" size="50" />
                 </li>
                 <li>
-                  <label for="numberingmethod">Numbering formula:</label>
-                  <input type="text" id="numberingmethod" name="numberingmethod" value="[% numberingmethod | html %]" />
+                  <label class="required" for="numberingmethod">Numbering formula:</label>
+                  <input type="text" id="numberingmethod" name="numberingmethod" value="[% numberingmethod | html %]" class="required" required="required" />
+                  <span class="required">Required</span>
                 </li>
                 <li>
                   <label for="displayorder">Display order:</label>
-- 
2.39.5