From b73230a5f45d799a248c767ef3d6f2d9e0e37da0 Mon Sep 17 00:00:00 2001 From: Andreas Roussos Date: Fri, 17 Feb 2023 16:05:20 +0100 Subject: [PATCH] Bug 32926: Assign unique ids to

elements If you perform a System preferences search for a common word such as "type", you lose the ability to expand or collapse some sections. In particular, you cannot expand/collapse the sections with names that appear more than once in the results page. All sections except the first one in each group of duplicates are affected by this. See https://imgur.com/a/NSslIcV for a demo. This patch fixes that by prepending the

ids with the top-level System preference section name to make them unique. Test plan: 1) Perform a System preferences search for a common word such as "type" or "log". In the results page, the "Policy" section will appear more than once. Now try to expand/collapse any "Policy" section but the first one. It won't work, only the first "Policy" section is toggled. 2) Apply this patch and refresh the page. 3) This time you should be able to expand or collapse all of the available system preference sections. 4) Clicking on the "View all xxx preferences" links on the right hand side should take you to the correct System preferences tab *and* automatically scroll the appropriate section into view at the top of the page. Signed-off-by: Fridolin Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 28a0c039fe9dec3ac97f069f30638ca24bcbf338) Signed-off-by: Matt Blenkinsop --- .../intranet-tmpl/prog/en/modules/admin/preferences.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt index b219e44983..701c653a73 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt @@ -70,16 +70,16 @@
-

[% LINE.title | html %]

+

[% LINE.title | html %]

- +
[% UNLESS ( loop.last ) %][% END %] [% ELSE %] -- 2.39.5
PreferenceValue