From b90662073ff99d25e0f32156924f79981f9d5707 Mon Sep 17 00:00:00 2001 From: Amit Gupta Date: Wed, 16 Aug 2017 17:56:17 +0530 Subject: [PATCH] Bug 19127: Fix Stored XSS in csv-profiles.pl To Test 1. Hit the page /cgi-bin/koha/tools/csv-profiles.pl?op=add_form 2. Add a text in the field Profile name, Profile description and Profile MARC fields that contains js 3. Save the page. 4. Notice js is execute 5. Apply patch and reload, the js is escaped Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- .../intranet-tmpl/prog/en/modules/tools/csv-profiles.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt index 40f64f51c3..181eb35d6c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt @@ -279,9 +279,9 @@ function reloadPage(p) { [% FOREACH csv_profile IN csv_profiles %] [% csv_profile.export_format_id %] - [% csv_profile.profile %] - [% csv_profile.description %] - [% csv_profile.content %] + [% csv_profile.profile |html %] + [% csv_profile.description |html %] + [% csv_profile.content |html %] [% csv_profile.csv_separator %] [% PROCESS type_description type_code = csv_profile.type %] [% PROCESS used_for_description used_for_code = csv_profile.used_for %] -- 2.39.5