From f8063726ba1c486d2a62be2a930fb5cac0797856 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 17 Oct 2018 19:11:29 -0300 Subject: [PATCH] Bug 21597: Field 'amount' doesn't have a default value Fix t/db_dependent/Accounts.t Default value could be 0, or left as it. It seems that the different initialisation we have in the code pass a value for 'amount' account_offsets.amount `amount` decimal(26,6) NOT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Field 'amount' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125 Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 82884b0bd81a79c9a0c700463f1fcc632314863c) Signed-off-by: Martin Renvoize --- t/db_dependent/Accounts.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t index f447d4658a..e9d7049500 100644 --- a/t/db_dependent/Accounts.t +++ b/t/db_dependent/Accounts.t @@ -814,7 +814,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub { my $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store(); my $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => -5 })->store(); - my $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment' })->store(); + my $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment', amount => 0 })->store(); purge_zero_balance_fees( 1 ); my $debit_2 = Koha::Account::Lines->find( $debit->id ); my $credit_2 = Koha::Account::Lines->find( $credit->id ); @@ -824,7 +824,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub { $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 5 })->store(); $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store(); - $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment' })->store(); + $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment', amount => 0 })->store(); purge_zero_balance_fees( 1 ); $debit_2 = $credit_2 = undef; $debit_2 = Koha::Account::Lines->find( $debit->id ); @@ -835,7 +835,7 @@ subtest "Koha::Account::non_issues_charges tests" => sub { $debit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store(); $credit = Koha::Account::Line->new({ borrowernumber => $patron->id, date => '1900-01-01', amountoutstanding => 0 })->store(); - $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment' })->store(); + $offset = Koha::Account::Offset->new({ credit_id => $credit->id, debit_id => $debit->id, type => 'Payment', amount => 0 })->store(); purge_zero_balance_fees( 1 ); $debit_2 = Koha::Account::Lines->find( $debit->id ); $credit_2 = Koha::Account::Lines->find( $credit->id ); -- 2.39.5