]> git.koha-community.org Git - koha.git/commit
Bug 15344: Remove unucessary call to GetMemberDetails
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 9 Dec 2015 17:00:10 +0000 (17:00 +0000)
committerFrédéric Demians <f.demians@tamil.fr>
Thu, 31 Dec 2015 17:08:27 +0000 (18:08 +0100)
commitf7c6e9f586667ea5dfdd5dd08a05ccb799e1d424
treecd0f649635e80f48edf1dcacbb1a6024479f3e1d
parentd4bcfef9d1aaa8048b91fbe1f1b9b51a09be2703
Bug 15344: Remove unucessary call to GetMemberDetails

This subroutine does a lot a processing and should only be called when
necessary.
In the get_template_and_user subroutine (so called from any pages of
Koha), it is call to pass the branchcode, title, firstname, surname and
borrowernumber values for the logged in user.
This subroutine calls GetMemberAccountRecords which retrieve the items
infos for all accountlines entries of the logged in user.
On members/members.pl, let's say you have 74 entries in the accountlines
tables, the page will execute 115 SELECT instead of 35 if you don't have any
accountlines entries.
With this patch, the number of SELECT is always 31.

To test this patch you should have technical skills to know what to do.

Note that USER_INFO was an array of... 1 element. Now it's a hashref.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit ac541e0fa1c11254e110d94eed64c358e02e8aab)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 44202df6acdfcfb371eccc6b8e8007a871304e49)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
C4/Auth.pm
admin/aqbudgets.pl
admin/aqplan.pl
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt