From 26efec07d7344ecf3c29981e735246dec6416bd1 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Sat, 24 Sep 2016 19:25:33 +0000 Subject: [PATCH] Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The patron search type is hard coded to 'contain' in circ/circulation.pl. This causes problems because a mis-scanned cardnumber can bring up the wrong patron. The example that our partner gave us involved scanning '1733', which doesn't match any borrowers when we do a 'start_with' search, but matches the cardnumber 'p291733'. If we follow the usage in members/member.pl, we can set searchtype in HTTP params, which is amenable to fixes in intranetuserjs Test Plan: 1) Apply this patch 2) Use the checkout search, not changes should be noted Extra credit: 1) Add javascript to intranetuserjs to add a hidden input named 'searchtype' with the value 'start_with' 2) Checkout searches should now give only results where a searched field starts with the given string(s) Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 56da7be50ada38bab6ec866f5915d55507c7d821) Signed-off-by: Frédéric Demians --- circ/circulation.pl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 38e2c49320..88d0bb59d1 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -140,6 +140,8 @@ my @failedreturns = $query->multi_param('failedreturn'); our %return_failed = (); for (@failedreturns) { $return_failed{$_} = 1; } +my $searchtype = $query->param('searchtype') || q{contain}; + my $findborrower = $query->param('findborrower') || q{}; $findborrower =~ s|,| |g; @@ -240,8 +242,8 @@ if ($findborrower) { my $results = C4::Utils::DataTables::Members::search( { searchmember => $findborrower, - searchtype => 'contain', - dt_params => $dt_params, + searchtype => $searchtype, + dt_params => $dt_params, } ); my $borrowers = $results->{patrons}; -- 2.39.5