From 1feeead338be4ae913e7caf10ebf840dc6de5eb6 Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Tue, 31 Oct 2023 13:33:19 -0400
Subject: [PATCH] Bug 34868: (QA follow-up) Rename new option, add comments

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 C4/SIP/ILS/Item.pm               | 3 ++-
 etc/SIPconfig.xml                | 2 +-
 t/db_dependent/SIP/Transaction.t | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm
index abd64fc216..5ed37bdea5 100644
--- a/C4/SIP/ILS/Item.pm
+++ b/C4/SIP/ILS/Item.pm
@@ -264,7 +264,8 @@ sub sip_circulation_status {
     my $self = shift;
     my $server = shift;
 
-    my $missing_status = $server->{account}->{missing_lost_status};
+    # Defines what lost status means "missing" for this SIP account
+    my $missing_status = $server->{account}->{lost_status_for_missing};
 
     if ( $self->{_object}->get_transfer ) {
         return '10'; # in transit between libraries
diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml
index 594ea46fa7..f4fd81a6d2 100644
--- a/etc/SIPconfig.xml
+++ b/etc/SIPconfig.xml
@@ -81,7 +81,7 @@
              format_due_date="0"
              inhouse_item_types=""
              inhouse_patron_categories=""
-             missing_lost_status="4"
+             lost_status_for_missing="4" <!-- defines which Koha lost status will return the circulation status 13 ( i.e. missing ) for this account -->
              blocked_item_types="VM|MU"
              seen_on_item_information="mark_found"> <!-- could be "keep_lost", empty to disable -->
              <!-- show_checkin_message: If enabled, successful checking responses will contain an AF screen message -->
diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t
index aa0a811ce2..56a810a736 100755
--- a/t/db_dependent/SIP/Transaction.t
+++ b/t/db_dependent/SIP/Transaction.t
@@ -1185,7 +1185,7 @@ subtest item_circulation_status => sub {
     $sip_item = C4::SIP::ILS::Item->new( $item->barcode );
     $status   = $sip_item->sip_circulation_status;
     is( $status, '12', "Item circulation status is lost" );
-    $status = $sip_item->sip_circulation_status( { account => { missing_lost_status => "1" } } );
+    $status = $sip_item->sip_circulation_status( { account => { lost_status_for_missing => "1" } } );
     is( $status, '13', "Item circulation status is missing" );
     $item->itemlost(0)->store();
 
-- 
2.39.5