]> git.koha-community.org Git - koha.git/commit
Bug 17988 - Select2 prevents correct tag expand/minimize functionality
authorOleg Vasylenko <synapse.ova@gmail.com>
Wed, 25 Jan 2017 10:01:05 +0000 (12:01 +0200)
committerKatrin Fischer <katrin.fischer.83@web.de>
Tue, 14 Feb 2017 19:39:49 +0000 (20:39 +0100)
commit37ad15eae7e8773ae8ee4cb342b5adf3d54d0ff0
treeb7fa4f35f49da271f44ad79f1150006135ba24e5
parent46506e215e42eaa854377337f8588436144ce1e3
Bug 17988 - Select2 prevents correct tag expand/minimize functionality

Overview:
Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure.
Because of that, expanding fields to show all hidden subfields does not work properly.

Steps to Reproduce:
1. Open some book in the editor or create new (cataloguing/addbiblio.pl)
2. Try to minimize or expand fields, that have among subfields the following:
— Thesaurus driven subfield → subfield with Select2
— Hidden subfield.

Actual Results:
 — some fields become hidden, some not, and vice versa
 — in the console, you'll see «Uncaught TypeError: Cannot read property 'match' of null»

Expected Results:
 — all subfields should minimize/maximize completely

Additional Information:
This happens because Select2 adds some divs, that do not have ID property.
The following patch adds check for the needed attribute existance.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 317abac238147cf20f09d2aa0b0dc069c12b0892)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
koha-tmpl/intranet-tmpl/prog/js/cataloging.js