]> git.koha-community.org Git - koha.git/commit
Bug 16202: GetIssuingCharges should return a collectable amount
authorColin Campbell <colin.campbell@ptfs-europe.com>
Tue, 5 Apr 2016 11:56:24 +0000 (12:56 +0100)
committerJulian Maurice <julian.maurice@biblibre.com>
Wed, 15 Mar 2017 11:35:16 +0000 (12:35 +0100)
commit5c152f45dfa2a0bc2af908b3e4d8676e75a19568
tree6b1cf1d8a1546a3284fff6fcbbeb77470eff84de
parent27217f2b3409100f3198d70fd701252637137264
Bug 16202: GetIssuingCharges should return a collectable amount

Charges should not include elements less than a penny/cent
they are not displayed but can be saved to the database
causing "odd" behaviour down the line

Make the routine round the resultant charge to nearest cent,
so consistent values are returned.
Removed the one case where it was rounded post call.
Although the main danger is values generated by the discount
calculation apply the rounding to all returned charges in case
the item charge is defined using the 3rd or 4th decimal
places.

NOTE: prove -v t/db_dependent/Circulation.t triggers the change.
      Though, all the returned amounts are 0.00 only.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit d84ed89557e2c921f261b1c620434d432dcbd3f7)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(cherry picked from commit 661e6389c990c603cbc6a0a9444c27ec9d01afe2)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
C4/Circulation.pm