]> git.koha-community.org Git - koha.git/commit
Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks...
authorJacek Ablewicz <abl@biblos.pk.edu.pl>
Mon, 23 Mar 2015 14:21:53 +0000 (15:21 +0100)
committerChris Cormack <chris@bigballofwax.co.nz>
Mon, 20 Apr 2015 10:08:36 +0000 (22:08 +1200)
commitafc3aa4007d7051028dba95d5462b886ba91644c
tree54bfe1da462df1271fa79a39dfdcb0bee427c550
parent05a7b7e457f3b1b380e23987481ca122c3fe964f
Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally

Existing framework code is currently not retained when local record
gets replaced during batch import, or when the restore/reverse function
is being used.

This patch fixes aforementioned issues by correcting outdated GetBiblio()
calls in C4/ImportBatch.pm

To test:

1/ try to replicate the issue: import some MARC records with
"Tools -> Stage MARC records for import" etc., using test setup,
matching rules and so on such that some existing records will get
replaced with imported ones
2/ observe that records replaced during import now open in the editor
with 'Default' framework, even if they have some other framework
set up previously
3/ apply patch
4/ redo 1/, confirming that this problem is no longer replicable
5/ try use 'restore' function with some freshly imported
records, ensure that original framework code got retained
in the records which had their imports reverted

NOTE: I confirmed this change by
1) git grep "=\s*GetBiblio\s*("
   -- this shows how GetBiblio is called elsewhere.
      It differed! So then...
2) vi C4/Biblio.pm
   /sub GetBiblio
   -- find the right one, notice it only returns a HASH ref,
      not an array.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 7c2fad1bafc38d7ed70e9508293136d89d77879c)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
C4/ImportBatch.pm