]> git.koha-community.org Git - koha.git/commit
Bug 22068: Prevent patrons to cancel article request they did not create
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 14 Feb 2019 20:03:17 +0000 (17:03 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 15 Apr 2019 10:57:24 +0000 (11:57 +0100)
commitdc32211a8ea12e67453e5af9edaac0a73b52e2de
treee1cbe77aebb7284a4525120f7f60b9a6b7c4c853
parentdf88d3c87a11feb17b7949d2a3567220a07bc196
Bug 22068: Prevent patrons to cancel article request they did not create

opac-article-request-cancel.pl doesn't check that the article request to
be cancelled actually belongs to the logged-in borrower. This results in
any logged-in user being able to cancel any article request just by
changing the id in the URL.

Test plan:
- Login with Patron P1, create an article request
- Cancel it
- Create another one
- Copy the cancellation link (must be /cgi-bin/koha/opac-article-request-cancel.pl?id=X)
- Login with Patron P2
- Hit the cancellation link
=> Without this patch the article request is cancelled
=> With this patch applied there is a 404 redirection

Note that the 404 will also appears when the article request id does not
exist.

Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 0b931d5de3c4fe9fa2b4823d9b8727b28a46aa7c)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
opac/opac-article-request-cancel.pl