From aa7c47cfed54dc4a971bb2eecc652b3e08d7cbbd Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 14 Jun 2022 08:21:42 -0300 Subject: [PATCH] Bug 30409: (QA follow-up) Avoid uninitialized variable warnings Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 730719c90c3f6eeef7ca3713282878b3ab7be527) Signed-off-by: Lucas Gass --- C4/Circulation.pm | 3 +++ t/Circulation_barcodedecode.t | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 71b549b6e3..bc1da9dad9 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -167,6 +167,9 @@ System Pref options. # sub barcodedecode { my ($barcode, $filter) = @_; + + return unless defined $barcode; + my $branch = C4::Context::mybranch(); $barcode =~ s/^\s+|\s+$//g; $filter = C4::Context->preference('itemBarcodeInputFilter') unless $filter; diff --git a/t/Circulation_barcodedecode.t b/t/Circulation_barcodedecode.t index 094d4aafc5..d5f31c9533 100755 --- a/t/Circulation_barcodedecode.t +++ b/t/Circulation_barcodedecode.t @@ -17,7 +17,8 @@ use Modern::Perl; -use Test::More tests => 28; +use Test::More tests => 29; +use Test::Warn; use C4::Context; use t::lib::Mocks; @@ -55,6 +56,11 @@ foreach my $filter (@filters) { } } +warnings_are + { C4::Circulation::barcodedecode(undef); } + [], + 'No warnings with undef barcode'; + # T-prefix style is derived from zero-padded "Follett Classic Code 3 of 9". From: # www.fsc.follett.com/_file/File/pdf/Barcode%20Symbology%20Q%20%20A%203_05.pdf # ~ 1 to 7 characters -- 2.39.5