From dc4aba6a46b4d14568dd48ce0fda548bb7013d7b Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 27 Jun 2023 13:23:08 +0000 Subject: [PATCH] Bug 34130: Make requested_date nullable in api definition This patch allows the requested_date for an ILL request to be NULL to accomodate older data To test: 1 - Install the Koha 2 Koha ILL plugin: https://gitlab.com/koha-community/plugins/koha-plugin-ill-koha 2 - Enable the ILL system preference 3 - Force an ILL request with minimal data from backend: INSERT INTO illrequests (borrowernumber,biblio_id,branchcode,backend,status) VALUES (5,3,'CPL','Koha','placed'); 4 - View the ILL table 5 - Error: {"message":"Expected string - got null.","path":"\/body\/0\/requested_date"} 6 - Apply patch 7 - Table loads successfully Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a8633a58129bc2bb6b26986973501aa6649f2c78) Signed-off-by: Martin Renvoize (cherry picked from commit 5edd76121ba4804599e3f3b29c0a223b2a9087d8) Signed-off-by: Pedro Amorim --- api/v1/swagger/definitions/ill_request.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/api/v1/swagger/definitions/ill_request.yaml b/api/v1/swagger/definitions/ill_request.yaml index 7c668bdfb5..2c585d0be5 100644 --- a/api/v1/swagger/definitions/ill_request.yaml +++ b/api/v1/swagger/definitions/ill_request.yaml @@ -24,7 +24,9 @@ properties: type: string description: Internal library identifier requested_date: - type: string + type: + - string + - "null" format: date description: Date the request was placed by the patron replied_date: -- 2.39.5