]> git.koha-community.org Git - koha.git/commit
Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version
authorDavid Cook <dcook@prosentient.com.au>
Fri, 28 Feb 2020 00:17:58 +0000 (00:17 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Wed, 1 Apr 2020 20:28:47 +0000 (20:28 +0000)
commit06c7de991ef72297fad75097f377889dc4438652
treef6e6cebb806e72467287dfc8e4f33a2a385de03f
parente145be8b6d8f36f5be968648606147775ecfaa59
Bug 24739: Perform IPv6 tests only if Net::Netmask is correct version

Test plan:
0. Apply patch
1. Set up Koha on stretch (e.g. koha/koha-testing:master)
2. perl t/Koha/Middlware/RealIP.t
3. Observe the following:
Subtest: IPv6 support
    ok 1 - Warn on IPv6 koha_trusted_proxies
    ok 2 - Unable to parse IPv6 address for trusted proxy, so ignore the X-Forwarded-For header
    1..2
ok 13 - IPv6 support

4. Set up Koha on buster (e.g. koha/koha-testing:master-buster)
5. perl t/Koha/Middlware/RealIP.t
6. Observe the following:
Subtest: IPv6 support
    ok 1 - Trust proxy (2001:db8:1234:5678:abcd:1234:abcd:1234) using IPv6 CIDR notation, so use the X-Forwarded-For header for the remote address
    1..1
ok 13 - IPv6 support

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
t/Koha/Middleware/RealIP.t