]> git.koha-community.org Git - koha.git/commit
Bug 20934: Fix display of old checkouts in the checkout history page
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 13 Jun 2018 16:26:43 +0000 (13:26 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 22 Jun 2018 12:47:48 +0000 (12:47 +0000)
commit117e3a18f5b7c24e6c9fb7eabb78ab1b5320cd14
tree9c56b99f362c54ad43bed6da9a859fe922840cda
parentc967e010c0110e562c4cc71bc5d18837a2a956a0
Bug 20934: Fix display of old checkouts in the checkout history page

Again a regression caused by
  commit fa54100dffe092e606f79b15692eedaf78f42e45
  Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory]

GetBiblioIssues does a union all with issues and old_issues, so we
should old_issues as well.
To make the join on the items table we need to define the item and
patron methods. For consistency the relationships have been redefined
(item instead of itemnumber, borrower instead of borrowernumber) in the
DBIx::Class definition.

This is not perfect but I think the best way to provide an easy to
backport patch.

It highlights that we need improvements in this area.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
The patch works as expected.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Old/Checkout.pm
Koha/Schema/Result/OldIssue.pm
catalogue/issuehistory.pl
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt