]> git.koha-community.org Git - koha.git/commit
Bug 25669: Use include_type_name parameter in ES calls
authorNick Clemens <nick@bywatersolutions.com>
Mon, 28 Mar 2022 12:00:25 +0000 (12:00 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Thu, 23 Jun 2022 14:30:31 +0000 (11:30 -0300)
commit150a4b03f337f6a58869c67d3681caa64441d53a
treef6c8a613df6c3df059b8a3891f90c7bd7bde5787
parenta4c5bd58361900983f870f1c0e7f497ae3618c85
Bug 25669: Use include_type_name parameter in ES calls

This patch includes the parameter:
include_type_name
on our ES calls

It removes the deprecation warning we are seeing, and should allow using ES7 with no other chnages.

For ES8 we will need to remove the hardcoded type,

I would suggest a second patch, with a new syspref "ElasticsearchLegacyType" set to 'True' by default.
Description can explain that this must be set to false, and data reindexed after upgrading to ES7 and before
upgrading to ES8 - then we can drop this pref when we drop ES7 support

When we drop ES6 support the pref can be set default true for upgrades, default 'false' for new installs

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/SearchEngine/Elasticsearch.pm
Koha/SearchEngine/Elasticsearch/Indexer.pm
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm