]> git.koha-community.org Git - koha.git/commit
Bug 29283: Don't attempt to cancel cancelled orders
authorNick Clemens <nick@bywatersolutions.com>
Wed, 20 Oct 2021 13:06:06 +0000 (13:06 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 2 Nov 2021 13:57:09 +0000 (14:57 +0100)
commit1de960e7e33e1b5e0c7493d7e1463d74182fdfe3
treef8bb9d0d3fcd8d2c03e118753479bfb7fbf8477a
parent90c577c06c29ee7d1614f62423552dfdea8d549e
Bug 29283: Don't attempt to cancel cancelled orders

When deleting a basket we cancel all the contained orders - when a
basket contains an order that was previously cancelled this can cause
an error if the biblio was deleted

When picking the orders to cancel, we should limit our search
to those not already cancelled.

To test:
- have a basket with at least one order
- click "Cancel order and delete catalog record", confirm cancellation of order and deletion of bib
- click "Delete basket", confirm deletion
- get error "Cannot insert order: Mandatory parameter biblionumber is missing at /kohadevbox/koha/acqui/basket.pl line 136.
 at /usr/share/perl/5.28/Carp.pm line 289"
- apply patch
- restart
- delete the basket
- success!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
acqui/basket.pl